Skip to content

Use h5py.check_string_dtype instead of deprecated h5py.check_dtype #11789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmuehlbauer merged 3 commits into from
Oct 22, 2026
+4 −2
Merged

Use h5py.check_string_dtype instead of deprecated h5py.check_dtype #11789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dc4b4b
Use h5py.check_string_dtype instead of deprecated h5py.check_dtype
kmuehlbauer Oct 22, 2026
4a4211c
Add whats-new.rst entry
kmuehlbauer Oct 22, 2026
26cbbe7
Merge branch 'main' into h5netcdf-compat
kmuehlbauer Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ New Features
variables of a section at once, and shows the expanded attributes and data
more compactly and indented below their variable (:pull:`11284`).
By `Michael Niklas <https://github.com/headtr1ck>`_.
- Use ``check_string_dtype()`` to detect variable-length strings in h5netcdf backend (:pull:`11789`).
By `Kai Mühlbauer <https://github.com/kmuehlbauer>`_.


Breaking Changes
Expand Down
4 changes: 2 additions & 2 deletions xarray/backends/h5netcdf_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ def open_store_variable(self, name, var):
},
)
else:
vlen_dtype = h5py.check_dtype(vlen=var.dtype)
if vlen_dtype is str:
string_info = h5py.check_string_dtype(var.dtype)
if string_info is not None and string_info.length is None:
encoding["dtype"] = str
else:
# xarray doesn't support writing arbitrary vlen dtypes yet, so
Expand Down
Loading