Repository navigation
Conversation
Dataset.apply, GroupBy.apply and Resample.apply have emitted a PendingDeprecationWarning, change that to FutureWarning instead. Add tests to check this warning for GroupBy.apply and Resample.apply.
Collaborator
|
Could you use emit_user_level_warning(
"Dataset.apply is deprecated, use Dataset.map instead.",
FutureWarning,
) |
Author
|
Got it, I saw that there were only two |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PendingDeprecationWarningis hidden by default, so users calling.applynever saw it.Changed the
PendingDeprecationWarningofDataset.apply, bothGroupBy.applymethods (DataArrayandDataset) and bothResample.applymethods to aFutureWarning, so that users can now see the warning.Tests were already there for checking
PendingDeprecationWarningofDataset.apply, changed that to check forFutureWarning. Added similar tests forGroupBy.applyandResample.apply( they check for the warning and whether the result of apply is same as map).Added this set of changes to the whats-new.rst under v2026.09.1's Deprecations section.
Checklist
whats-new.rst