Repository navigation
Collect the as_timedelta NotImplementedError test - #11783
Merged
headtr1ck merged 1 commit intoOct 22, 2026
Merged
Conversation
`as_timedelta_not_implemented_error` sits between two tests in test_cftime_offsets.py and asserts that `Tick().as_timedelta()` raises NotImplementedError, but the name has no `test_` prefix, so pytest has never collected it. Nothing else in the repository references the name. Renaming it collects and passes: the file goes from 2861 to 2862 tests. Co-authored-by: Claude <noreply@anthropic.com>
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as_timedelta_not_implemented_errorinxarray/tests/test_cftime_offsets.py:1543asserts thatTick().as_timedelta()raisesNotImplementedError. The name has notest_prefix, so pytest has never collected it, and nothing else in the repository references the name.Renaming it is the whole change. On current
main,pytest xarray/tests/test_cftime_offsets.pyis 2861 passed; with the rename it is 2862 passed, and the new test passes on its own.AI disclosure: the change was written by Claude Code, including the commit message and this description. The commit carries the co-authorship trailer.
[This is Claude Code on behalf of Dylan Pulver]