Skip to content

Separate the tables in the benchmark PR comment - #11771

Merged
headtr1ck merged 1 commit into
pydata:mainfrom
headtr1ck:fix-benchmark-comment-tables
Oct 21, 2026
Merged

headtr1ck merged 1 commit into
pydata:mainfrom
headtr1ck:fix-benchmark-comment-tables

Conversation

@headtr1ck

Copy link
Copy Markdown
Collaborator

Description

Follow-up to #11683: with mixed benchmark results (e.g. #11746), the PR comment shows the second table's header and |---| line as rows of the first table. With --split --only-changed, asv compare prints the tables of the different groups right after each other without a blank line, so markdown renders them as one table.

  • Insert a blank line before every table header but the first, so improvements and regressions are two separate tables.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.
      Tools: Claude Code with Opus 5.5

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the Automation Github bots, testing workflows, release automation label Oct 21, 2026
@headtr1ck
headtr1ck enabled auto-merge (squash) October 21, 2026 06:02
@headtr1ck
headtr1ck merged commit 30439ba into pydata:main Oct 21, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation Github bots, testing workflows, release automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant