Repository navigation
Fix test_setitem error message regex for numpy dev - #11737
Merged
Merged
Conversation
numpy dev no longer uses the np.str_ repr in the 'could not convert string to float' message. Co-authored-by: Claude <noreply@anthropic.com>
headtr1ck
added
topic-testing
upstream issue
plan to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
numpy dev prints
'a'instead ofnp.str_('a')in the "could not convert string to float" message, so the regex tightened in #11728 now accepts both.Checklist
whats-new.rstAI Disclosure
Tools: Claude Code