Preserve rustup-managed files in Ubuntu runner images - #798
Merged
Merged
Conversation
alex
previously approved these changes
Oct 1, 2026
alex
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the stable Rust toolchain in the Ubuntu armv7 runner fails while uninstalling Cargo because the image deleted
share/man/man1/cargo.1, which is still recorded in rustup’s component manifest. This blocks the Thumb stable job in verified-garbage #453 before compilation (failure log).Preserve the Rust documentation/manpages, LLVM tools, sanitizer runtimes, and wasm linker recorded in rustup’s manifests. Keep binary stripping and libLLVM deduplication. This increases image size but allows rustup to uninstall and update the baked-in toolchain correctly.
Enable rustup’s
RUSTUP_PERMIT_COPY_RENAMEfallback so toolchain updates can move directories on Docker overlay filesystems. Without it, the ppc64le runner fails withInvalid cross-device linkwhile backing upshare/doc/cargo.Add an Ubuntu image CI check that removes Cargo, LLVM tools, rustc, and rust-std in a disposable container. This exercises the failure path deterministically even when stable has not changed since the image was built. PR builds test the locally built image; main builds pull the newly published image rather than testing the previous cached tag.
Validation:
cargo.1failure with rustup 1.29.1 after deleting manpages from an isolated macOS toolchain copy.actionlint -shellcheck=), andgit diff --checkpass. Full actionlint reports a pre-existing SC2086 warning in the Node version setup step.