Conversation
Contributor
Adds a multi-layer pouch SPM in which each layer solves the 1D heat equation across the electrode sandwich (negative electrode | separator | positive electrode) with the standard finite-volume resolution, rather than the 2-node-per-layer profile the 3D thermal models produce when mesh_h >> L_x. Adjacent layers conduct across the inter-layer thermal contact resistance, ported from MultiLayer3DThermalSPM: the interface flux q = (T_right,i - T_left,i+1) / R_th is applied as a matched pair of Neumann conditions, so the heat leaving layer i at its right face is the heat entering layer i+1 at its left face. Note that PyBaMM's finite-volume Neumann value is dT/dx rather than the outward normal derivative, so both sides take dT/dx = -q / lambda. Includes an example script plotting the through-stack temperature profile and a changelog entry. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Contributor
Author
|
Hi @BradyPlanden I will review this today thanks for the ping. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new 3D thermal model, capable of simulating multi-layer stacked pouch cells, where independent electrochemical environments can exist as different stack layers in the cell. Heat is generated differentially at different layers.
Fixes #5505
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests