refactor(secrets): simplify local bootstrap - #169
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the local secrets bootstrap workflow for live testing by removing the dedicated secret-bootstrap test harness and ensuring normal verification (pnpm verify) remains secretless, while constraining secrets:setup to write a fixed, ignored .env.local output.
Changes:
- Removed the standalone
scripts/secrets-setup.test.shharness and dropped it frompackage.jsonscripts /verify. - Updated
scripts/secrets-setup.shto always write to.env.local(noSECRETS_OUTPUToverride). - Updated contributor/operator docs to reflect the simplified secrets setup flow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/secrets-setup.test.sh | Removed the dedicated local secrets setup test harness. |
| scripts/secrets-setup.sh | Constrained secrets setup output to a fixed .env.local path. |
| package.json | Removed test:secrets and stopped running it as part of verify. |
| CONTRIBUTING.md | Updated contributor guidance for pnpm secrets:setup. |
| AGENTS.md | Updated agent/operator guidance for pnpm secrets:setup in live testing notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
18 tasks
Contributor
|
🎉 This PR is included in version 11.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review aids
Risks
Verification
pnpm verifySummary by cubic
Streamlines local secrets setup by removing the standalone harness and enforcing
.env.localas the only output.pnpm verifyremains secretless; live tests still use maintainer-supplied SOPS ciphertext.Refactors
scripts/secrets-setup.test.shandtest:secrets; dropped fromverify.scripts/secrets-setup.shalways writes.env.localand now errors ifSECRETS_OUTPUTis set; keeps gitignore and 0600 checks.pnpm secrets:setupflow.Migration
pnpm secrets:setupto render.env.local; do not setSECRETS_OUTPUT(the script will fail if present).pnpm verifyno longer runs secrets tests.Written for commit 82a3b53. Summary will update on new commits.