Skip to content

ci(release): fix Homebrew bot identity lookup quoting - #51

Merged
altaywtf merged 1 commit into
mainfrom
ci/fix-homebrew-bot-identity-quoting
Aug 3, 2026
Merged

ci(release): fix Homebrew bot identity lookup quoting#51
altaywtf merged 1 commit into
mainfrom
ci/fix-homebrew-bot-identity-quoting

Conversation

@altaywtf

@altaywtf altaywtf commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix nested-quote breakage in the Homebrew release bot user-id lookup
  • Fail the step if the resolved id is not numeric

Test plan

  • CI green on this PR
  • Next Homebrew tap update resolves bot email correctly

Review aids

Before: echo "user-id=$(gh api "/users/...")" (broken nested quotes)
After: multiline run: | with numeric validation

Made with Cursor


Summary by cubic

Fix the Homebrew release bot user ID lookup in CI by switching to a multiline script with safe quoting and numeric validation. Prevents broken gh api calls and fails fast if the ID isn’t numeric.

  • Bug Fixes
    • Use multiline run: | with set -euo pipefail to avoid nested-quote issues in gh api.
    • Resolve /users/${APP_SLUG}[bot], validate the ID is digits only, then write user-id to $GITHUB_OUTPUT.

Written for commit 71246ca. Summary will update on new commits.

Use a multiline script so nested quotes do not break gh api, and fail if the resolved user id is not numeric.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI review requested due to automatic review settings August 3, 2026 19:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a quoting bug in the Homebrew release workflow by replacing an inline echo "user-id=$(...)” with a multiline script, ensuring the gh api call is correctly quoted and the resolved bot user ID is validated as numeric before being written to $GITHUB_OUTPUT.

Changes:

  • Switch the “Resolve Homebrew release bot user ID” step to a multiline run: | script to avoid nested-quote breakage.
  • Add set -euo pipefail and validate the gh api-returned .id is digits-only, failing fast otherwise.
  • Pass the app slug via APP_SLUG env var to simplify and harden the command construction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@altaywtf
altaywtf merged commit 5360541 into main Aug 3, 2026
8 checks passed
@altaywtf
altaywtf deleted the ci/fix-homebrew-bot-identity-quoting branch August 3, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants