Repository navigation
feat: add support ubuntu26.04 - #1688
Conversation
|
Hello everyone, can I have some news about this PR ? |
|
Hello @Tonguechaude ! Thanks for submitting the PR! The engineering team is currently actively at work on putting Ubuntu 26.04 as a documented supported version for Puppet agents. This PR will be good to help expand that into modules as well. I've approved the CI to run and it looks like spec tests have some failures. Looks like the latest We'll need engineering feedback on this one before merging as they will need to run some acceptance tests and make sure the module has the latest systemd in scope so that CI passes. |
|
Hello, thank you for your comment ! I've launch some acceptance test and it was good for me. I'm waiting their feedbacks ! |
|
It seems that #1691 was submitted to resolve the issue with the test suite. I've already run acceptance tests on it and it looks good, so once engineering has a chance do a review and merge up we should be able to move forward with testing here. |
7f0951b to
49bf947
Compare
|
Running CI tests for this PR here: #1695 |
Register ubuntu:26.04 in images.json so the existing build pipeline produces and publishes a litmusimage/ubuntu:26.04 image for both amd64 and arm64/v8, mirroring the Ubuntu 24.04 configuration. Requested to support acceptance testing for puppetlabs/puppetlabs-postgresql#1688
Register ubuntu:26.04 in images.json so the existing build pipeline produces and publishes a litmusimage/ubuntu:26.04 image for both amd64 and arm64/v8, mirroring the Ubuntu 24.04 configuration. Uses the puppetcore8 collection because apt.puppet.com does not yet publish a puppet-release package for the resolute (26.04) codename, so the default install script 404s; Puppetcore's nightly mirror already supports it. Same workaround as the Debian 13 (trixie) image. Requested to support acceptance testing for puppetlabs/puppetlabs-postgresql#1688
49bf947 to
1e4ce54
Compare
1e4ce54 to
51f649e
Compare
|
Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/36469903779?pr=1695 I rebased and reran the acceptance tests. Mostly green, with failures on AlmaLinux 8, AlmaLinux 9, and Debian 11. These failures all match to existing infra/provisioning issues that are also seen in Nightly runs against the main branch and not introduced by this PR. Important to note: Ubuntu 26.04 acceptance testing was included in this run and ran green. Given the PR is aimed at adding support for Ubuntu 26.04, and there are no failures introduced by the PR, testing looks good. Still needs a code review from engineering, but testing passed! |
|
Thanks for the contribution, @Tonguechaude, and for your patience while we got this tested. Review summary: LGTM.
Testing: Thank you @jst-cyr for running the full CI on a copy of this PR in #1695, since the acceptance tests can't run directly on fork PRs. Results: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/36469903779
Approving. Thanks again! |
51f649e to
ec436ef
Compare
Summary
This PR simply add support for ubuntu-26.04
Additional Context
I use this module on a ubuntu 26 and got an undef for psql version. So I need to specify the version.
Related Issues (if any)
N/A
Checklist
puppet apply)