Skip to content

feat: add support ubuntu26.04 - #1688

Merged
SugatD merged 1 commit into
puppetlabs:mainfrom
Tonguechaude:allow-ubuntu-26-04
Oct 30, 2026
Merged

SugatD merged 1 commit into
puppetlabs:mainfrom
Tonguechaude:allow-ubuntu-26-04

Conversation

@Tonguechaude

Copy link
Copy Markdown
Contributor

Summary

This PR simply add support for ubuntu-26.04

Additional Context

I use this module on a ubuntu 26 and got an undef for psql version. So I need to specify the version.

Related Issues (if any)

N/A

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Tonguechaude

Copy link
Copy Markdown
Contributor Author

Hello everyone, can I have some news about this PR ?

@jst-cyr

jst-cyr commented Aug 4, 2026

Copy link
Copy Markdown
Member

Hello @Tonguechaude ! Thanks for submitting the PR! The engineering team is currently actively at work on putting Ubuntu 26.04 as a documented supported version for Puppet agents. This PR will be good to help expand that into modules as well.

I've approved the CI to run and it looks like spec tests have some failures. Looks like the latest puppet\systemd version isn't supported in the metadata scope: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/30556250961/job/92061937919?pr=1688

We'll need engineering feedback on this one before merging as they will need to run some acceptance tests and make sure the module has the latest systemd in scope so that CI passes.

@Tonguechaude

Copy link
Copy Markdown
Contributor Author

Hello, thank you for your comment ! I've launch some acceptance test and it was good for me. I'm waiting their feedbacks !

@jst-cyr

jst-cyr commented Aug 6, 2026

Copy link
Copy Markdown
Member

It seems that #1691 was submitted to resolve the issue with the test suite. I've already run acceptance tests on it and it looks good, so once engineering has a chance do a review and merge up we should be able to move forward with testing here.

@jst-cyr

jst-cyr commented Aug 17, 2026

Copy link
Copy Markdown
Member

Running CI tests for this PR here: #1695

jst-cyr added a commit to puppetlabs/litmusimage that referenced this pull request Aug 18, 2026
Register ubuntu:26.04 in images.json so the existing build pipeline
produces and publishes a litmusimage/ubuntu:26.04 image for both
amd64 and arm64/v8, mirroring the Ubuntu 24.04 configuration.

Requested to support acceptance testing for
puppetlabs/puppetlabs-postgresql#1688
jst-cyr added a commit to puppetlabs/litmusimage that referenced this pull request Aug 18, 2026
Register ubuntu:26.04 in images.json so the existing build pipeline
produces and publishes a litmusimage/ubuntu:26.04 image for both
amd64 and arm64/v8, mirroring the Ubuntu 24.04 configuration.

Uses the puppetcore8 collection because apt.puppet.com does not yet
publish a puppet-release package for the resolute (26.04) codename,
so the default install script 404s; Puppetcore's nightly mirror
already supports it. Same workaround as the Debian 13 (trixie) image.

Requested to support acceptance testing for
puppetlabs/puppetlabs-postgresql#1688
@jst-cyr

jst-cyr commented Sep 28, 2026

Copy link
Copy Markdown
Member

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/36469903779?pr=1695

I rebased and reran the acceptance tests. Mostly green, with failures on AlmaLinux 8, AlmaLinux 9, and Debian 11. These failures all match to existing infra/provisioning issues that are also seen in Nightly runs against the main branch and not introduced by this PR.

Important to note: Ubuntu 26.04 acceptance testing was included in this run and ran green. Given the PR is aimed at adding support for Ubuntu 26.04, and there are no failures introduced by the PR, testing looks good.

Still needs a code review from engineering, but testing passed!

@SugatD SugatD self-assigned this Oct 30, 2026
@SugatD

SugatD commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution, @Tonguechaude, and for your patience while we got this tested.

Review summary: LGTM.

  • manifests/globals.pp: adds the Ubuntu 26.04 → PostgreSQL 18 default mapping. This fixes the undef version you hit, and it follows the existing pattern.
  • metadata.json: adds 26.04 to the supported Ubuntu releases.

Testing: Thank you @jst-cyr for running the full CI on a copy of this PR in #1695, since the acceptance tests can't run directly on fork PRs. Results: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/36469903779

  • Spec tests pass on Puppet 8 and Puppet 9.
  • Ubuntu 26.04 acceptance passes on both puppetcore8 and puppetcore9.
  • The failures (AlmaLinux 8/9, Debian 11, RedHat-7) are on platforms this change doesn't touch. Several of them also appear in nightly runs on main, so they're existing infrastructure issues and not caused by this PR.

Approving. Thanks again!

@SugatD
SugatD force-pushed the allow-ubuntu-26-04 branch from 51f649e to ec436ef Compare October 30, 2026 05:20

@SugatD SugatD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@SugatD
SugatD merged commit ae81b3f into puppetlabs:main Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants