Repository navigation
Conversation
|
|
|
Thank you for submitting the PR, @wardhus . I authorized the CI to run and it looks like we have a Rubocop failure:
This seems to be caused by removing the use of |
`docker compose config` prints fully qualified image names such as docker.io/library/postgres:18-alpine, while `docker ps` prints the short familiar form (postgres:18-alpine). The exists? check compared the two strings literally, so any project whose compose file uses a docker.io/ prefix was never seen as running and `docker compose up` was executed on every Puppet run. Strip the implicit Docker Hub prefixes from the configured image name so the comparison matches. Also route the explicit `image:` case through get_image so the normalization applies there too. Fixes puppetlabs#967
42a3fd5 to
004ff82
Compare
|
Should be fine now :) |
|
Thanks @wardhus ! I've approved the basic CI to run so we should get some initial feedback from Rubocop and unit tests against 8.0. If that looks good, I'll trigger off an acceptance test branch to run the full suite. |
|
Running CI tests for this PR here: #1090 |
|
🟢 Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-docker/actions/runs/40922351147?pr=1090 All green! Tests have passed for all platforms. Needs engineering review. |
docker compose configprints fully qualified image names such as docker.io/library/postgres:18-alpine, whiledocker psprints the short familiar form (postgres:18-alpine). The exists? check compared the two strings literally, so any project whose compose file uses a docker.io/ prefix was never seen as running anddocker compose upwas executed on every Puppet run.Strip the implicit Docker Hub prefixes from the configured image name so the comparison matches. Also route the explicit
image:case through get_image so the normalization applies there too.Fixes #967
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)