Fix typechecking in six GCP TypeScript examples - #2994
Merged
Conversation
Part of #2993 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0189zT7gdmHRM8ntk8N3h9Uj
corymhall
approved these changes
Sep 2, 2026
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six of the GCP TypeScript examples failed
tsc. All six now pass, verified by typechecking every GCP TypeScript example in the repo with no regressions.Two are not purely mechanical.
gcp-ts-gke-serviceaccounthad"n1-standard-1" || config.get("machineType"), which is backwards, so themachineTypeconfig key was silently ignored; reversing it makes that key take effect. Ingcp-ts-slackbotthe express import sits inside a closure that gets serialized into a Cloud Function, so it usesimport express = require("express"); a default import would compile to__importDefault(...)and hand the closure serializer a synthetic wrapper rather than a module reference.These are typecheck-only fixes. None of the six has integration test coverage, so none is verified at
pulumi up. That gap is #2993. The two remaining failures are multicloud and out of scope here, tracked in #2992.Stacked on #2991; retarget to
masteronce that merges.Part of #2993