fix(build): migrate to cranelift-isle 0.132.1 + wasmparser 0.251 — tag builds again (closes #198, v1.1.13)#199
Merged
Merged
Conversation
…he tag builds (closes #198) v1.1.12's committed deps (cranelift-isle 0.132.1, wasmparser 0.251 — pulled by the wasmtime-45 bump) landed without the source migration, so the tag failed `cargo install` from a clean checkout (gale could not build the #196 fix). Earlier session builds only passed on a stale Cargo.lock. cranelift-isle 0.132.1: - build.rs CodegenOptions literal → add `..Default::default()` (grew fields) - types.isle → drop duplicate `(type u32 ...)` (prelude provides it now) - loom-shared/src/lib.rs → `extern crate alloc` (generated code emits alloc::) wasmparser 0.251: - import parsing → new `Imports` enum: handle `Single(usize, Import)`; the compact-import encodings (Compact1/Compact2) are NOT modeled, so parse_wasm returns Err on them and the caller keeps original bytes (fail-safe) - ComponentExternName: tuple `.0` → struct field `.name` - drop removed `cm_async_builtins` feature flag Verified: builds clean against committed deps; 395 lib + 85 integration pass; behavioral falcon gate unchanged (run-stabilization 0.023399856, run-position-hold 0.1317415 == original) — import-parse migration + #196 fail-safe both behaviorally correct. Bumps 1.1.12 -> 1.1.13. Closes #198. Trace: REQ-12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gale #198 — v1.1.12 doesn't build from tag
v1.1.12's committed deps (
cranelift-isle 0.132.1,wasmparser 0.251, pulled by the wasmtime-45 bump) landed without the source migration, socargo installfrom the tag failed. (Earlier builds only passed on a stale Cargo.lock — the non-reproducibility gale flagged.)Migrated
cranelift-isle 0.132.1:
CodegenOptionsliteral →..Default::default(); dropped duplicate(type u32 …)(prelude provides it);extern crate allocfor generatedalloc::paths.wasmparser 0.251: import parsing → new
Importsenum (Single(usize, Import); compact encodingsCompact1/Compact2are not modeled →parse_wasmerrs → caller keeps original bytes, fail-safe);ComponentExternName.0→.name; dropped removedcm_async_builtins.Validation
Builds clean against committed deps. 395 lib + 85 integration pass. Behavioral falcon gate unchanged —
run-stabilization0.023399856,run-position-hold0.1317415 (matches original; import-parse migration + #196 fail-safe both behaviorally correct).Note
A committed
Cargo.lock/pinned deps would prevent this from-tag non-reproducibility class; tracked separately.Known-red (pre-existing)
Closes #198.
🤖 Generated with Claude Code