fix(rivet): resolve 3 duplicate-artifact-id collisions — validate FAIL→PASS#48
Open
avrabe wants to merge 1 commit into
Open
fix(rivet): resolve 3 duplicate-artifact-id collisions — validate FAIL→PASS#48avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…L->PASS - safety-context C-1/C-2 (safety_case.yaml) collided with STPA controllers C-1/C-2 (stpa_controllers_ucas.yaml, heavily referenced by UCA target: links) -> renamed the safety-contexts to CTX-1/CTX-2 (CTX- prefix was free; SC- is system-constraints) - duplicate FV-US-003 in verification.yaml (Clippy-lint vs k_object-delegation) -> the delegation verification renumbered to the free FV-US-002 (+ prose ref) - rivet validate: FAIL (3 errors) -> PASS (30 warnings); 0 broken cross-refs Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3fd98a3 to
f9a4a1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rivet validatewas FAIL (3 errors) on duplicate artifact IDs — silent overwrites in the trace graph. All three are genuine ID-namespace collisions:C-1/C-2safety-context(safety_case.yaml) vscontroller(stpa_controllers_ucas.yaml)target:links) → renamed the safety-contexts toCTX-1/CTX-2(CTX- was free; SC- is taken by system-constraints)FV-US-003sw-verifications in verification.yaml (Clippy-lint vs k_object-delegation)FV-US-002(+ its prose ref)Result
rivet validate: FAIL (3 errors, 28 warnings) → PASS (30 warnings), 0 broken cross-refs.The remaining 30 warnings are lifecycle-coverage gaps (311 missing unit/integration/system verification links) — a separate traceability-audit task, not addressed here. The
variants/bindings.yaml'missing field name' warning is a pre-existing rivet variant-config schema mismatch (non-blocking).🤖 Generated with Claude Code