Reimplement serial_deglitch and mv_filter#293
Merged
Conversation
phsauter
force-pushed
the
phsauter/serial_deglitch
branch
3 times, most recently
from
a6bedb7 to
e24443f
Compare
colluca
requested changes
Apr 24, 2026
Contributor
colluca
left a comment
colluca
left a comment
There was a problem hiding this comment.
Mostly looks good to me, there's only one corner case that could possibly create issues.
phsauter
force-pushed
the
phsauter/serial_deglitch
branch
from
e24443f to
2924b5f
Compare
phsauter
force-pushed
the
phsauter/serial_deglitch
branch
from
2924b5f to
eddac50
Compare
colluca
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines a new expected behavior of
serial_deglitchandmv_filter.The second is different enough that I decided to change its name to
majority_vote_filter.Replaces #252, addresses #256