Skip to content

Bump common_cells to v2 - #4

Draft
colluca wants to merge 5 commits into
mainfrom
common-cells-v2
Draft

colluca wants to merge 5 commits into
mainfrom
common-cells-v2

Conversation

@colluca

@colluca colluca commented Jun 25, 2026

Copy link
Copy Markdown

No description provided.

colluca and others added 5 commits June 25, 2026 16:24
Replace fifo_v3/stream_fifo with cc_fifo/cc_stream_fifo and rename
`FFARN to `FF to align with the common_cells v2 API.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@alessiomangone

Copy link
Copy Markdown

In src/axi_to_obi.sv, this PR removes the .testmode_i connection from the obi_mux instance i_mux_banks.

But obi_mux still has a testmode_i input:

  • in obi 0.1.7, which this PR uses (see Bender.yml);
  • on obi main.

So this input is now unconnected in every axi_to_obi. QuestaSim warns [TFMPC] Missing connection for port 'testmode_i'. Verilator warns PINMISSING.

obi PR #36 removes the input from obi_mux. Until axi_obi uses an obi version with that change, I suggest tying the input to 1'b0:

  ) i_mux_banks (
    .clk_i,
    .rst_ni,
    .testmode_i     ( 1'b0      ),
    .sbr_ports_req_i( obi_reqs  ),

This is safe: obi_mux only passes testmode_i to its internal fifo_v3.

I have used this change since October, with QuestaSim 2026.1 and Verilator 5.050. The warnings are gone, and my tests pass. If it helps, I can open a pull request against this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants