Skip to content

Fix performance and functional issues in cache controller - #59

Merged
DiyouS merged 1 commit into
mainfrom
fix/hashing
Nov 9, 2026
Merged

DiyouS merged 1 commit into
mainfrom
fix/hashing

Conversation

@DiyouS

@DiyouS DiyouS commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Fix a bug in the controller's hashing function, which caused a previous test case to fail.

Copilot AI balanced review requested due to automatic review settings November 9, 2026 12:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Changes to dirty-line flush sequencing and writeback backpressure require RTL simulation to verify data integrity, forward progress, and the re-enabled timing assertion, but simulation was unavailable in this review.

No open issues 🎉

What changed in this PR

This PR updates the cache-controller dependency to address the reported hashing bug and restores enforcement of the previously waived L1 bypass timing check.

Changes:

  • Advances the insitu-cache dependency revision.
  • Makes the bypass-disabled timing check report and count failures instead of waiving them.
File Description
software/​tests/​l1-bypass/​main.c Restores failure reporting and counting for the bypass-disabled timing check.
Bender.lock Pins insitu-cache to the revision intended to fix the cache-controller issues.

Review effort: Balanced

@DiyouS
DiyouS merged commit 9b6afa8 into main Nov 9, 2026
10 checks passed
@DiyouS
DiyouS deleted the fix/hashing branch November 10, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants