Use default XDG state dir for cachedir#11
Open
mochaaP wants to merge 1 commit intopuiterwijk:masterfrom
Open
Conversation
Use ~/.local/state/openidc for as default cachedir.
Author
|
I could submit another PR if you would like me to renovate the project and retarget it to Py3.7+. fedpkg relies on this and we likely need to move away from deprecated python package setups |
Author
|
cc @puiterwijk |
carlwgeorge
reviewed
Apr 18, 2026
| self.useragent = useragent or 'python-openid-client/%s' % \ | ||
| release.VERSION | ||
| self.cachedir = os.path.expanduser(cachedir or '~/.openidc') | ||
| self.cachedir = os.path.expanduser(cachedir or '~/.local/state/openidc') |
There was a problem hiding this comment.
According to the XDG Base Directory Specification, this should try to read the $XDG_CACHE_HOME environment variable first, and if that is unset then fall back to $HOME/.cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ~/.local/state/openidc for as default cachedir.
I did not pull in https://github.com/srstevenson/xdg-base-dirs or any other
environment variable detections since I'm unsure about the supported
Python version. This is good enough for standard Fedora setups.