Repository navigation
fix(security): npm audit fix; require Node 20 - #12
Merged
Merged
Conversation
The module-level setInterval kept the event loop alive, so `node --test` never finished and every CI test job ran until GitHub's 6-hour cancel.
npm audit fix (no --force) clears all 9 advisories (1 critical, 4 high). @modelcontextprotocol/sdk 1.32 pulls @hono/node-server 2.x, which needs Node >= 20, so engines and the CI matrix drop Node 18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
securityCI job (npm audit --audit-level=high) has failed onmainsince June: 9 advisories (1 critical, 4 high, 3 moderate, 1 low), includingqsDoS advisories.Fix
npm audit fixwithout--force. Onlypackage-lock.jsonchanges and all ranges stay semver-compatible. Notable bumps:@modelcontextprotocol/sdk1.29.0 → 1.32.1,@hono/node-server1.19.14 → 2.1.5,qs6.15.1 → 6.16.0,hono4.12 → 4.13. The lockfile also picks up thepublora-mcp-stdiobin entry it was missing.@hono/node-server2.x requires Node ≥ 20. With the new lockfile, 2 MCP-session tests fail on Node 18, which reached end of life in April 2025.engines.nodeis now>=20.0.0and the CI matrix is[20, 22]. The Dockerfile already usesnode:20-alpine.@publora/mcp-server@1.1.0on npm still declares>=18. This PR changes only the repository; the npm package changes only on the next publish.Stacked on #11 (the hanging-tests fix); merge #11 first.
Verification (Docker, from a clean
npm ci)npm testnpm audit --audit-level=highnpm ci --ignore-scripts