[CORE] Fix some logic errors reported in #4214 - #4271
Merged
Conversation
Owner
|
I'l validate this one next week, after my vacaccions, so next week. |
Contributor
Author
|
Test case as follow, previously these programs failed and this pr makes them run properly. |
ptitSeb
reviewed
Sep 11, 2026
ptitSeb
reviewed
Sep 11, 2026
1. Preserve `state` across spaces in printf/wprintf stack aligners. A space inside a format specifier should not reset the parsing state. 2. Initialize and reset the GVariant parser nesting counter (`tmp`) when entering `a` (array) and `@` (GVariant*) states. 3. Advance `st` only when an argument is actually read from the stack in `myStackAlignGVariantNew`. Previously `++st` was executed unconditionally, even for register arguments, causing subsequent stack arguments to be read from wrong offsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve
stateacross spaces and%mmodifiers.Initialize GVariant parser state(
tmp) foraand@formats.Advance the
stonly when an argument is read from stack.Ignore NULL in XCB display registrations.
Fix space handling in the 32-bit wide scanf parser.