Choosing a target document should not start a sync - #53
Merged
Conversation
Picking a target says nothing about which way the user wants to reconcile the two sides, and they have a button for each. The handler only skipped the push when the file was already linked, so a first link still pushed. Linking now links and stops, from every entry point. Closes #52 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking a document says nothing about which direction the user wants —
there is a push button and a pull button for exactly that. The handler
only skipped the push when the file was already linked, so a first link
fell through to
handleGoogleDocsSync('push').Linking now links and stops, from every entry point. Renamed
handleGoogleDocsPickAndSync→handleGoogleDocsPickTarget, since it nolonger syncs.
Verification
Nothing automated covers this: the behaviour lives in
renderer.ts,which has no test harness — the components around it are tested, the
wiring between them is not. This is a five-line deletion verified by
reading the one call site and by driving the app, not by a test I watched
fail. Saying so plainly rather than claiming coverage that does not
exist.
pnpm test1033 passed / 62 files · typecheck clean · lint clean.Closes #52
🤖 Generated with Claude Code