Skip to content

Port pstack 0.15.42 (upstream bf0c7cd) - #31

Merged
caelaxie merged 2 commits into
mainfrom
cursor/port-pstack-0.15.42-1df3
Nov 16, 2026
Merged

caelaxie merged 2 commits into
mainfrom
cursor/port-pstack-0.15.42-1df3

Conversation

@caelaxie

Copy link
Copy Markdown
Contributor

Summary

Ports upstream pstack 0.15.36 → 0.15.42 from https://github.com/cursor/plugins at bf0c7cd80abdbf7fe47b634978a7d1b4071f71a7 (feat(pstack): new default models, one-file why and how, statechart fixes, sharpen and reflect text, 2026-11-15). The previous pin was c742dd61706fbacc1b95f1a20b7b988cf096ce6c. Only the pstack/ tree was ported.

  • how is one read-only explainer subagent. skills/how/references/ is gone.
  • why is one file that answers from commits and PR discussions. skills/why/references/ is gone.
  • /setup-pstack drops the retired how/why role lines, writes # defaults: 2, and on a rerun replaces old defaults it recognizes (here, inherit and the retired lines), tells the user which, and keeps other role choices.
  • Sharpen, reflect, poteto-mode, playbooks, architect, arena, blast-radius, recall, teach, no-comments, the guide, the README skill table, and the dormant benny pack follow the same text changes.
  • Statechart mermaid drawing, run.ts, and the chart/cli/corpus/render tests come across, including test/drawn.ts.
  • DSH routes stay inherit in ~/.agents/pstack-models.md. Cursor model names were not copied over the DSH setup, README, or guide wording. Tool names stay the DSH set.
  • deslop, control-cli, and control-ui are unchanged. The DSH pin stays @deepseek-ai/dsh@0.2.2-rc.3. No peer bump.

No issue to close.

Proof

npm test:

> dsh-pstack@0.15.42 test
> node scripts/validate.mjs

Validated 61 skills, 23 playbooks, 24 principles, and the DSH bundle manifest.

Also, matching the PR job in .github/workflows/ci.yml: node --check on the bundle entry points, bash -n on the three shell scripts, and under .agents/skills/poteto-mode/scripts bun run typecheck plus bun run test (61 pass, 0 fail). Statechart test/chart.test.ts and test/cli.test.ts: 178 pass, 0 fail. The scheduled corpus/render job was not run locally.

Harness, same runtime CI pins (@deepseek-ai/dsh@0.2.2-rc.3, not @next). No registry token was required.

npm install -g --prefix /tmp/dsh-prefix pnpm@10 @deepseek-ai/dsh@0.2.2-rc.3
export PATH="/tmp/dsh-prefix/bin:$PATH"
export DSH_HOME=/tmp/dsh-home-proof DSH_PROFILE=ci
dsh plugin --profile ci add /agent/repos/dsh-pstack
dsh plugin --profile ci list --depth 0
dsh --profile ci --dump-config > "$DSH_HOME/dump-config.yml"
grep -F '# == dsh-pstack' "$DSH_HOME/dump-config.yml"
grep -F -- '- id: pstack' "$DSH_HOME/dump-config.yml"
grep -F 'name: dsh-pstack' "$DSH_HOME/dump-config.yml"
node .github/prove-dsh-profile.mjs
dsh: 0.2.2-rc.3
dependencies:
+ dsh-pstack link:/agent/repos/dsh-pstack
# == dsh-pstack
- id: pstack
  name: dsh-pstack
started bundles: @deepseek-ai/dsh-base, dsh-pstack
pstack skills (61):
... control-cli, control-ui, deslop, how, poteto-mode, reflect, setup-pstack, sharpen, statechart, why ...

The prove script's required set (poteto-mode, setup-pstack, deslop, control-cli, control-ui) is present, and so are how, why, sharpen, reflect, and statechart. No missing skills. No harness failure.

Open in Web Open in Cursor 

Bring the how and why skills, setup rerun behavior, sharpen wording, and statechart fixes across, keeping DSH routes on inherit.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested.

three minimum-parity issues on head 9105193 against upstream bf0c7cd. versions, layout, and embedded skill parity otherwise pass.

  1. .agents/skills/poteto-mode/playbooks/perf-issue.md:6 still says 2. how to ground hypotheses. Don't claim a perf ceiling without running it first. that file is unchanged in this diff, but the line is still wrong against upstream. replace it with 2. Trace the code to ground hypotheses. Don't claim a perf ceiling without running it first. keep the model inherit.
  2. .agents/skills/setup-pstack/SKILL.md step 3(a–b) (lines 40–45, unchanged in this diff) and docs/guide/01-setup.md:37 still use absolute effort ranks (unlimited = top, large = one down, and so on). budget must be relative to each role's own default: large keeps, unlimited raises one reported route effort step, medium lowers one, small lowers two, clamped to that route's reported effort range; inherit unchanged.
  3. setup-pstack still writes and leaves one-seat panels, but the skills now use three inherit seats. the four panel roles (arena runners, arena cross-judge pool, architect runners, interrogate reviewers) must template inherit, inherit, inherit. migrate an exact one-inherit old default only when the defaults: 2 marker is absent, and preserve real custom routes. step 3(c) should start three seats, not two. also remove the extra line-34 sentence To drop a pin this step does not recognize..., which is absent upstream.

please fix these and ping for re-review. no merge until they land.


Every other value is the user's choice and stays. Tell the user which retired lines you dropped and which values you replaced. To drop a pin this step does not recognize, delete that role's line or the file first.

### 3. Budget, map, and confirm

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step 3(a–b) just below still uses absolute effort ranks (unlimited = top reported, large = one down, medium = two, small = three). those lines are unchanged in this diff, but they need to budget relative to each role's own default: large keeps, unlimited raises one reported route effort step, medium lowers one, small lowers two, clamped to that route's reported effort range. inherit stays unchanged.

Comment thread docs/guide/01-setup.md Outdated
@@ -36,7 +36,7 @@ With model selection off, every role uses `inherit`, which means the child keeps

The budget sets the starting effort. `unlimited` is the top reported effort, `large` is one step down, `medium` is two steps down, and `small` is three steps down. The exact effort ids come from `list_subagent_models` for that route.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repeats the same absolute effort ranks. it needs the same per-role rule as setup-pstack: large keeps the role's default, unlimited raises one reported route effort step, medium lowers one, small lowers two, clamped to that route's reported effort range; inherit unchanged.

Comment thread .agents/skills/setup-pstack/SKILL.md Outdated

- Drop every retired-role line, including `how explorer`, `how explainer`, `why investigators`, and `why synthesizer`.
- A value of `inherit` on a role that step 5 still lists is the old default. The new default is still `inherit`, so leave it.
- A panel value (`arena runners`, `arena cross-judge pool`, `architect runners`, `interrogate reviewers`) that is exactly `inherit` is the old one-seat default. Leave it unless step 3 picks panel routes. A panel list that names any real route is the user's choice and stays.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not leave an exact one-inherit panel as the old default. migrate that one-seat value to inherit, inherit, inherit only when the defaults: 2 marker is absent. preserve real custom routes.

Comment thread .agents/skills/setup-pstack/SKILL.md Outdated
- A value of `inherit` on a role that step 5 still lists is the old default. The new default is still `inherit`, so leave it.
- A panel value (`arena runners`, `arena cross-judge pool`, `architect runners`, `interrogate reviewers`) that is exactly `inherit` is the old one-seat default. Leave it unless step 3 picks panel routes. A panel list that names any real route is the user's choice and stays.

Every other value is the user's choice and stays. Tell the user which retired lines you dropped and which values you replaced. To drop a pin this step does not recognize, delete that role's line or the file first.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the extra sentence To drop a pin this step does not recognize, delete that role's line or the file first. it is absent upstream.

Comment thread .agents/skills/setup-pstack/SKILL.md Outdated
@@ -38,7 +46,7 @@ The default role table is step 5's shape. If `~/.agents/pstack-models.md` exists

**(c) Pick two base routes.** Ask which detected route code delegates should use and which route judgment and prose should use. Offer `inherit` and every detected route. The defaults are `inherit` for both, which means "let the parent model do it". Panels use the two base routes as their starting seats.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step 3(c) should start three seats, not two. panels now use three inherit seats.

Comment thread .agents/skills/setup-pstack/SKILL.md Outdated
why synthesizer: inherit
reflect tooling: inherit
reflect judgment, divergent, synthesizer: inherit
arena runners: inherit

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the four panel roles (arena runners, arena cross-judge pool, architect runners, interrogate reviewers) must template inherit, inherit, inherit. swarm workers can stay a single inherit.

Trace perf hypotheses in the playbook, move each role's effort from its own default, and write three inherit seats for the panel roles.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
@cursor

cursor Bot commented Nov 16, 2026

Copy link
Copy Markdown

Ready for re-review on 35dc4f8. The three notes are in, and this is not merged.

  1. perf-issue.md step 2 now traces the code to ground hypotheses. The delegate still defaults to inherit.
  2. /setup-pstack step 3(a–b) and docs/guide/01-setup.md budget from each role's own default: large keeps it, unlimited raises one reported route effort step, medium lowers one, small lowers two, clamped to that route's reported range. inherit is unchanged.
  3. The four panel roles template inherit, inherit, inherit. A file without # defaults: 2 migrates an exact one-seat inherit to those three seats and keeps a list that names a real route. Step 3(c) starts three seats. The extra "drop a pin" sentence is gone from the skill. swarm workers stays one inherit.

npm test passed: 61 skills, 23 playbooks, 24 principles.

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-review on head 35dc4f8. pass.

the three notes from 9105193 landed: perf-issue step 2 traces the code; setup-pstack and docs/guide/01-setup.md budget from each role's own default; the four panel roles template inherit, inherit, inherit, step 3(c) starts three seats, and the extra drop-a-pin sentence is gone from the skill. swarm workers stays one inherit. versions 0.15.42 / bf0c7cd, embedded skills byte-identical, no cursor-team-kit mentions in the ported text.

validate dsh bundle and mount bundle in dsh are green on this exact head. no issue to close. merging.

@caelaxie
caelaxie merged commit f91273c into main Nov 16, 2026
3 checks passed
@caelaxie
caelaxie deleted the cursor/port-pstack-0.15.42-1df3 branch November 16, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants