Repository navigation
Port pstack 0.15.42 (upstream bf0c7cd) - #31
Conversation
Bring the how and why skills, setup rerun behavior, sharpen wording, and statechart fixes across, keeping DSH routes on inherit. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
changes requested.
three minimum-parity issues on head 9105193 against upstream bf0c7cd. versions, layout, and embedded skill parity otherwise pass.
.agents/skills/poteto-mode/playbooks/perf-issue.md:6still says2.howto ground hypotheses. Don't claim a perf ceiling without running it first.that file is unchanged in this diff, but the line is still wrong against upstream. replace it with2. Trace the code to ground hypotheses. Don't claim a perf ceiling without running it first.keep the model inherit..agents/skills/setup-pstack/SKILL.mdstep 3(a–b) (lines 40–45, unchanged in this diff) anddocs/guide/01-setup.md:37still use absolute effort ranks (unlimited= top,large= one down, and so on). budget must be relative to each role's own default: large keeps, unlimited raises one reported route effort step, medium lowers one, small lowers two, clamped to that route's reported effort range; inherit unchanged.- setup-pstack still writes and leaves one-seat panels, but the skills now use three inherit seats. the four panel roles (
arena runners,arena cross-judge pool,architect runners,interrogate reviewers) must templateinherit, inherit, inherit. migrate an exact one-inheritold default only when thedefaults: 2marker is absent, and preserve real custom routes. step 3(c) should start three seats, not two. also remove the extra line-34 sentenceTo drop a pin this step does not recognize..., which is absent upstream.
please fix these and ping for re-review. no merge until they land.
|
|
||
| Every other value is the user's choice and stays. Tell the user which retired lines you dropped and which values you replaced. To drop a pin this step does not recognize, delete that role's line or the file first. | ||
|
|
||
| ### 3. Budget, map, and confirm |
There was a problem hiding this comment.
step 3(a–b) just below still uses absolute effort ranks (unlimited = top reported, large = one down, medium = two, small = three). those lines are unchanged in this diff, but they need to budget relative to each role's own default: large keeps, unlimited raises one reported route effort step, medium lowers one, small lowers two, clamped to that route's reported effort range. inherit stays unchanged.
| @@ -36,7 +36,7 @@ With model selection off, every role uses `inherit`, which means the child keeps | |||
|
|
|||
| The budget sets the starting effort. `unlimited` is the top reported effort, `large` is one step down, `medium` is two steps down, and `small` is three steps down. The exact effort ids come from `list_subagent_models` for that route. | |||
There was a problem hiding this comment.
this repeats the same absolute effort ranks. it needs the same per-role rule as setup-pstack: large keeps the role's default, unlimited raises one reported route effort step, medium lowers one, small lowers two, clamped to that route's reported effort range; inherit unchanged.
|
|
||
| - Drop every retired-role line, including `how explorer`, `how explainer`, `why investigators`, and `why synthesizer`. | ||
| - A value of `inherit` on a role that step 5 still lists is the old default. The new default is still `inherit`, so leave it. | ||
| - A panel value (`arena runners`, `arena cross-judge pool`, `architect runners`, `interrogate reviewers`) that is exactly `inherit` is the old one-seat default. Leave it unless step 3 picks panel routes. A panel list that names any real route is the user's choice and stays. |
There was a problem hiding this comment.
do not leave an exact one-inherit panel as the old default. migrate that one-seat value to inherit, inherit, inherit only when the defaults: 2 marker is absent. preserve real custom routes.
| - A value of `inherit` on a role that step 5 still lists is the old default. The new default is still `inherit`, so leave it. | ||
| - A panel value (`arena runners`, `arena cross-judge pool`, `architect runners`, `interrogate reviewers`) that is exactly `inherit` is the old one-seat default. Leave it unless step 3 picks panel routes. A panel list that names any real route is the user's choice and stays. | ||
|
|
||
| Every other value is the user's choice and stays. Tell the user which retired lines you dropped and which values you replaced. To drop a pin this step does not recognize, delete that role's line or the file first. |
There was a problem hiding this comment.
remove the extra sentence To drop a pin this step does not recognize, delete that role's line or the file first. it is absent upstream.
| @@ -38,7 +46,7 @@ The default role table is step 5's shape. If `~/.agents/pstack-models.md` exists | |||
|
|
|||
| **(c) Pick two base routes.** Ask which detected route code delegates should use and which route judgment and prose should use. Offer `inherit` and every detected route. The defaults are `inherit` for both, which means "let the parent model do it". Panels use the two base routes as their starting seats. | |||
There was a problem hiding this comment.
step 3(c) should start three seats, not two. panels now use three inherit seats.
| why synthesizer: inherit | ||
| reflect tooling: inherit | ||
| reflect judgment, divergent, synthesizer: inherit | ||
| arena runners: inherit |
There was a problem hiding this comment.
the four panel roles (arena runners, arena cross-judge pool, architect runners, interrogate reviewers) must template inherit, inherit, inherit. swarm workers can stay a single inherit.
Trace perf hypotheses in the playbook, move each role's effort from its own default, and write three inherit seats for the panel roles. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
|
Ready for re-review on
|
caelaxie
left a comment
There was a problem hiding this comment.
re-review on head 35dc4f8. pass.
the three notes from 9105193 landed: perf-issue step 2 traces the code; setup-pstack and docs/guide/01-setup.md budget from each role's own default; the four panel roles template inherit, inherit, inherit, step 3(c) starts three seats, and the extra drop-a-pin sentence is gone from the skill. swarm workers stays one inherit. versions 0.15.42 / bf0c7cd, embedded skills byte-identical, no cursor-team-kit mentions in the ported text.
validate dsh bundle and mount bundle in dsh are green on this exact head. no issue to close. merging.
Summary
Ports upstream pstack 0.15.36 → 0.15.42 from https://github.com/cursor/plugins at
bf0c7cd80abdbf7fe47b634978a7d1b4071f71a7(feat(pstack): new default models, one-file why and how, statechart fixes, sharpen and reflect text, 2026-11-15). The previous pin wasc742dd61706fbacc1b95f1a20b7b988cf096ce6c. Only thepstack/tree was ported.howis one read-only explainer subagent.skills/how/references/is gone.whyis one file that answers from commits and PR discussions.skills/why/references/is gone./setup-pstackdrops the retired how/why role lines, writes# defaults: 2, and on a rerun replaces old defaults it recognizes (here,inheritand the retired lines), tells the user which, and keeps other role choices.run.ts, and the chart/cli/corpus/render tests come across, includingtest/drawn.ts.inheritin~/.agents/pstack-models.md. Cursor model names were not copied over the DSH setup, README, or guide wording. Tool names stay the DSH set.deslop,control-cli, andcontrol-uiare unchanged. The DSH pin stays@deepseek-ai/dsh@0.2.2-rc.3. No peer bump.No issue to close.
Proof
npm test:Also, matching the PR job in
.github/workflows/ci.yml:node --checkon the bundle entry points,bash -non the three shell scripts, and under.agents/skills/poteto-mode/scriptsbun run typecheckplusbun run test(61 pass, 0 fail). Statecharttest/chart.test.tsandtest/cli.test.ts: 178 pass, 0 fail. The scheduled corpus/render job was not run locally.Harness, same runtime CI pins (
@deepseek-ai/dsh@0.2.2-rc.3, not@next). No registry token was required.The prove script's required set (
poteto-mode,setup-pstack,deslop,control-cli,control-ui) is present, and so arehow,why,sharpen,reflect, andstatechart. No missing skills. No harness failure.