Skip to content

Fix portreview audit issues 16-27 - #28

Merged
caelaxie merged 1 commit into
mainfrom
cursor/portreview-audit-16-27-3657
Nov 9, 2026
Merged

caelaxie merged 1 commit into
mainfrom
cursor/portreview-audit-16-27-3657

Conversation

@caelaxie

@caelaxie caelaxie commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Closes #16
Closes #17
Closes #18
Closes #19
Closes #20
Closes #21
Closes #22
Closes #23
Closes #24
Closes #25
Closes #26
Closes #27

Notes

Open in Web Open in Cursor 

Restore the upstream logo and the audit's smallest DSH fixes: Benny jobs
use schedule_create, session directories follow projectKey, and the bot UI
keeps its key on the server.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
@cursor

cursor Bot commented Nov 9, 2026

Copy link
Copy Markdown

Harness proof for this branch (d13a5d0), same pins as CI: Node 22, pnpm@10, @deepseek-ai/dsh@0.2.2-rc.1.

npm test (node scripts/validate.mjs):

Validated 61 skills, 23 playbooks, 24 principles, and the DSH bundle manifest.

Mount (DSH_HOME isolated, profile ci):

dsh plugin --profile ci add <checkout>
dsh plugin --profile ci list --depth 0
dsh --profile ci --dump-config
node .github/prove-dsh-profile.mjs

dsh --version printed 0.2.2-rc.1. pnpm --version printed 10.34.9. Plugin list shows dsh-pstack@link:<checkout> and no skip.

Dump layer, last lines of the composed tree, with no disabled or skip on the row:

# == dsh-pstack
- id: pstack
  name: dsh-pstack

prove-dsh-profile.mjs started bundles @deepseek-ai/dsh-base, dsh-pstack and listed 61 pstack skills, including poteto-mode, setup-pstack, deslop, control-cli, and control-ui.

Headless turn on a profile that also has the checkout added (dsh --profile headless --json --approval-policy never "/poteto-mode reply with the single word pong"), with DEEPSEEK_API_KEY unset. Exit 1, as expected:

dsh: MISSING_CREDENTIAL: llm-deepseek: no API key for provider route "deepseek-official"; store DEEPSEEK_API_KEY through the credentials service (the web Models page writes it), or export DEEPSEEK_API_KEY in the launching environment

The JSON stream opened a session in this checkout (turn_start then turn_end with code: MISSING_CREDENTIAL). No model call ran.

Local checks around the changed scripts: session-log.sh --list and --grep resolve /Users/you/My Projects/repo-style cwd to --Users-you-My~0020Projects-repo-- and ignore the old slash-to-dash slug. worktree-audit.sh records LAST_CHAT from a 30-day-old session.v1.jsonl and from a newer session.jsonl.zstd. The make-bot-ui sample server throws without BOT_UI_KEY, and POST /wake with no Authorization header returns 202. assets/logo.png matches cursor/plugins c742dd6 pstack/assets/logo.png (cmp, 361140 bytes, 512×512 8-bit RGB).

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass. each hunk matches the smallest fix in #16–#27; logo blob is 3754e87 (361140 bytes), identical to cursor/plugins c742dd6. no cursor-team-kit mention added, embedded deslop/control-cli/control-ui still load per the proof. dsh mount proof on d13a5d0 (plugin add + list + dump-config + prove-dsh-profile, 61 skills) and Validate DSH bundle + Mount bundle in DSH green. squash-merging.

@caelaxie
caelaxie merged commit e12d636 into main Nov 9, 2026
3 checks passed
@caelaxie
caelaxie deleted the cursor/portreview-audit-16-27-3657 branch November 9, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment