Repository navigation
Port upstream pstack 0.15.42 - #66
Conversation
Bring in cursor/plugins#1236 (bf0c7cd) for the pstack tree: one-file why and how, new default model tiers, statechart SANY and Mermaid fixes, and the sharpen and reflect text. Antigravity paths and model tiers stay. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
changes requested.
three minimum-parity issues on head d045f325 against upstream bf0c7cd. the rest of the port holds: sanctioned antigravity layout, .antigravity-plugin/plugin.json 0.15.42, embedded skills identical, no cursor-team-kit, why/how collapse and statechart parity pass, and green ci plus agy 1.5.9 install/list on this head.
skills/setup-pstack/SKILL.mdstep 3(b) still assigns every roleflashat medium and every roleflash_liteat small, instead of lowering each role from its own default onflash_lite<flash<pro. large keeps; unlimited raises one capped; medium lowers one (pro→flash,flash→flash_lite, each panel entry too); small lowers two;inherit/inherit-parent/autostay.docs/guide/01-setup.mdneeds the same per-role rule, and should drop the added verification/trivial-edits wording that is not upstream.skills/poteto-help/SKILL.mdrewrites the close-call line without a harness need. restore exactly:/howexplains what the code does./whyexplains the reasons./teachruns one or both and explains the result plainly.- the README model paragraph adds
swarm workers, verification, and trivial edits go to flash.which is absent upstream. delete that sentence and keep the required tier substitutions in the remaining clauses.
please fix these and ping for re-review. no merge until they land.
| - `small - flash_lite reasoning` | ||
|
|
||
| **(b) Apply it.** Build the working table from the skill defaults, and on a re-run keep any role you changed by tier, list, or alias (`inherit`, `inherit-parent`, `auto`). `unlimited` upgrades `flash` roles to `pro`. `large` keeps the skill defaults (`pro` for judgment, prose, and hardest tasks; `flash` for fast code, explorer, investigator, and worker roles). `medium` sets every role to `flash`. `small` sets every role to `flash_lite`. `inherit`, `inherit-parent`, and `auto` do not change. | ||
| **(b) Apply it.** Build the working table from the skill defaults, and on a re-run keep any role you changed by tier, list, or alias (`inherit`, `inherit-parent`, `auto`). `unlimited` upgrades `flash` roles to `pro`. `large` keeps the skill defaults (`pro` for code delegates, judgment, prose, and hardest tasks; `flash` for swarm workers, reflect tooling, verification, and trivial mechanical edits). `medium` sets every role to `flash`. `small` sets every role to `flash_lite`. `inherit`, `inherit-parent`, and `auto` do not change. |
There was a problem hiding this comment.
this still flattens every role to flash at medium and flash_lite at small. budget relative to each role's own default on flash_lite < flash < pro: large keeps; unlimited raises one capped; medium lowers one (pro→flash, flash→flash_lite, each panel entry too); small lowers two; inherit / inherit-parent / auto stay. also drop the added "verification, and trivial mechanical edits" wording from the large-default list; it is not upstream.
| [`/setup-pstack`](../../skills/setup-pstack/SKILL.md) detects the model tiers you want to use, asks for a reasoning budget, shows you each role (code delegates, judgment, the review panels), and asks what you want. Answer the questions. It writes `~/.gemini/config/rules/pstack-models.md`, a small rule every pstack skill reads. | ||
|
|
||
| The defaults use `flash` for code-writing and exploration delegates and `pro` for deep reasoning and judgment. `unlimited` and `large` use `pro` for judgment and `flash` for fast execution; `medium` and `small` shift roles down toward `flash` and `flash_lite` to spend fewer tokens. | ||
| The defaults are the same as the `large` budget. Code delegates, prose, and judgment use `pro`, and the hardest changes do too. Swarm workers, verification, and trivial edits use `flash`. `unlimited` upgrades `flash` roles to `pro`. `large` keeps that split. `medium` and `small` shift roles toward `flash` and `flash_lite` and spend fewer tokens. |
There was a problem hiding this comment.
this needs the same per-role budget rule as setup-pstack step 3(b), not a vague shift toward flash and flash_lite. also delete the added "Swarm workers, verification, and trivial edits use flash." wording; it is not upstream. keep the required tier substitutions in the remaining clauses.
| Close calls: | ||
|
|
||
| - `/how` explains what the code does. `/why` explains the reasons. `/teach` runs one or both and explains the result plainly. | ||
| - `/how` explains what the code does, with one read-only subagent. `/why` answers from the record, not the code. `/teach` runs one or both and explains the result plainly. |
There was a problem hiding this comment.
this rewrites the upstream close-call line without a harness need. restore exactly:
/how explains what the code does. /why explains the reasons. /teach runs one or both and explains the result plainly.
| new here? the [pstack guide](./docs/guide/README.md) walks you through a first real task, from setup and prompting through verification and overnight runs. stuck, or unsure which skill fits? ask [`/poteto-help`](./skills/poteto-help/SKILL.md). | ||
|
|
||
| that's it. the other skills are situational, and the mode skill uses them for you as needed. out of the box the mode splits work by model strength: code delegates (feature, refactoring, bug fix, perf, hillclimb) go to flash, while the hardest changes, prose, and judgment go to pro. the default panel is pro / flash. [`/setup-pstack`](./skills/setup-pstack/SKILL.md) changes any of it. | ||
| that's it. the other skills are situational, and the mode skill uses them for you as needed. out of the box the mode splits work by model strength: code delegates (feature, refactoring, bug fix, perf, hillclimb), prose, and judgment go to pro, and the hardest changes do too. swarm workers, verification, and trivial edits go to flash. the default panel is pro / flash. [`/setup-pstack`](./skills/setup-pstack/SKILL.md) changes any of it. |
There was a problem hiding this comment.
delete the added sentence swarm workers, verification, and trivial edits go to flash. it is absent upstream. keep the required tier substitutions in the remaining clauses.
Medium and small move each role from its own default on the tier ladder. Restore the poteto-help close call and drop the README and guide sentences that were not in upstream. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
|
The three notes are in
Harness proof on this head: |
caelaxie
left a comment
There was a problem hiding this comment.
pass.
the four notes are fixed on head 210afbe. setup-pstack 3(b) and the setup guide now move each role from its own default on flash_lite < flash < pro (large keeps, unlimited raises one capped at pro, medium lowers one including each panel entry, small lowers two; inherit / inherit-parent / auto stay), and the extra verification/trivial-edits wording is gone. the poteto-help close-call is restored verbatim. the added readme sentence is deleted, with the required tier substitutions kept. the follow-up is +4/-4 on just those four files. validate plugin is green on this head, and the pr body has agy 1.5.9 install/list/validate with the installed sha 210afbe. not a draft. merging.
summary
Ports upstream cursor/plugins#1236 (
pstack/only) from0.15.36atc742dd61706fbacc1b95f1a20b7b988cf096ce6cto0.15.42atbf0c7cd80abdbf7fe47b634978a7d1b4071f71a7.The monorepo range also contains commits outside
pstack/. Those are not in this port.harness/pstack/claude-code/is not ported. This repo does not shipdocs/harness/, so the Claude Code adapter edit in #1236 has no file here.what landed
whyis one short file. Its references, investigators, synthesizer, and model roles are gone.recallstarts its own investigator per source.blast-radiusandteachno longer point at partswhyno longer has.howis one file and one read-only subagent. Poteto-mode no longer runshowon the nontrivial-change trigger. Investigation, Feature, Bug fix, Hillclimb, Perf issue, Refactoring, architect, no-comments, and comment-sicko trace the code themselves. Benny traces directly and no longer requireshow.teachandpoteto-helpstill cataloghow.sharpenasks the rewritten prompt to prototype any choice an experiment can settle.reflect's drifting-detail example is a function rename.check()reruns SANY in plain mode and reports that run's error section, capped at 40 lines. Mermaid arrows from outside a parent state end at the parent's border. The start marker still continues to the inner state.0.15.42.antigravity-only adaptations
.antigravity-plugin/plugin.json. This port has no rootplugin.jsonand no.cursor-pluginmanifest.howspawnsinvoke_subagentwithTypeName: "research"(read-only).recall's per-source investigators useTypeName: "self", becauseresearchhas no MCP tools. Existing path, tool, and transcript adaptations stay.invoke_subagentstill takespro,flash,flash_lite, orinherit, so the new slugs map onto those tiers. Code delegates (feature, refactoring, bug-fix, perf-issue, hillclimb), prose, and judgment arepro. The hardest-tasks role stayspro: Antigravity has no tier abovepro, soclaude-fable-5-2-maxandclaude-opus-5-5-xhighare the same tier. Swarm workers and reflect tooling stayflash. Review and design panels staypro, flash. There is no third tier for the upstream fable / opus / gemini panel.flash_lite<flash<pro.largekeeps the default.unlimitedraises one step, capped atpro.mediumlowers one step.smalllowers two.inherit,inherit-parent, andautostay.setup-pstackwrites# defaults: 2. A rule without that line is an older setup. It namesgrok-*once as an old slug. Oldflashdefaults on the code-delegate roles takepro. Other chosen values stay. Thehowandwhyroles are dropped.arena,swarm, andreflectalready stated those tiers, so their default lines did not need new wording. The reflect synthesizer example did change.harness proof
Head
210afbe6c9a7b1732946a5c4e882d4ecf6bf66be.agy1.5.9. Commands ran on this commit. Statechart sources are unchanged fromd045f325ce86b8eaf68ca40a38e84395e448e1cb, where the suite was 340 tests, 270 pass, 0 fail, 70 skipped (TLC corpus runs skip withoutTLA2TOOLS).Loaded skills include
how,why,recall,setup-pstack,sharpen,reflect,poteto-mode,poteto-help,statechart,teach,blast-radius,architect,arena,no-comments, andswarm. Benny's three skills are in the installed tree underautomations/benny/skills/with valid frontmatter. They are not registered slash skills. Strict validate of the installed copy passed. The repo CI structural check printedValidated 61 skills, 2 agents, and 23 playbooks.