Repository navigation
fix(check-plan): validate Swarm UI plan.json and Pstack v2 dependencies - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
skills/pstack/scripts/check-plan.mjsrejected Swarm UIplan.jsonfiles as invalid Markdown and checked stale v1playbooks/and~/.gemini/config/plugins/pstack/markers in multi-phaseplan.mdfiles. This change updates the validator and its test suite to enforce theswarm_paneJSON schema and Pstack v2 multi-PR dependency rules deterministically.What changed
check-plan.mjs. AddedcheckJsonPlanto validategoal,tasks, andthreadsexact keys, word-count bounds, reserved and whitespace-free worker names, and one-to-one worker coverage across1to6threads.check-plan.mjs. Updated required markers totopologies/and~/.gemini/config/plugins/agy-pstack-next/, and addedvalidatePrDependenciesto reject unknown PR references, self-dependencies,None.mixed with PR references, and dependency cycles.check-plan.test.mjs. Expanded test coverage to 16 tests spanning validplan.jsonexamples, schema rejections, v2 marker enforcement, PR dependency DAGs and cycles, unreadable inputs, anddecision-log.sh.Scope
skills/pstack/scripts/check-plan.mjsandskills/pstack/scripts/check-plan.test.mjs.Blast Radius
Callers invoking
check-plan.mjson legacy v1plan.mdplans usingplaybooks/or~/.gemini/config/plugins/pstack/will now fail validation until migrated to Pstack v2 paths. Valid Pstack v2plan.mdfiles and Swarm UIplan.jsonfiles require no changes.Verification
node --test skills/pstack/scripts/check-plan.test.mjspassed 16 of 16 tests.node --test hooks/guard.test.mjspassed 20 of 20 tests.node --test skills/pstack/scripts/watch-pr.test.mjspassed 56 of 56 tests.agy plugin validate --strict --json .passed with 0 findings across 14 skills and 1 hook.