Skip to content

impr: Optimized the format_number function #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Sep 13, 2026
+5 −12
Merged

impr: Optimized the format_number function #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91a05c2
impr: Optimized the `format_number` function
DebanKsahu Sep 6, 2026
6f480d6
test: Updated `test_format_number` with new number which are closer t…
DebanKsahu Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions pyperf/_formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,8 @@ def format_number(number, unit=None, units=None):
number = '10^%s' % pow10

if isinstance(number, int) and number > 8192:
pow2 = 0
x = number
while x >= 2:
x, r = divmod(x, 2)
pow2 += 1
if r:
break
if not r:
number = '2^%s' % pow2
if number & (number-1) == 0:
number = '2^%s' % (number.bit_length() - 1)

if not unit:
return str(number)
Expand Down
6 changes: 3 additions & 3 deletions pyperf/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,15 @@ def test_format_number(self):
self.assertEqual(format_number(33 * 10 ** 4, 'unit'),
'330000 units')

# powers of 10
# powers of 2
self.assertEqual(format_number(2 ** 10, 'unit'),
'1024 units')
self.assertEqual(format_number(2 ** 15, 'unit'),
'2^15 units')
self.assertEqual(format_number(2 ** 15),
'2^15')
self.assertEqual(format_number(2 ** 10 + 1, 'unit'),
'1025 units')
self.assertEqual(format_number(2 ** 15 - 1), '32767')
self.assertEqual(format_number(2 ** 15 + 1), '32769')

def test_format_filesize(self):
self.assertEqual(format_filesize(0),
Expand Down