refactor: Made _T_DIST_95_CONF_LEVELS a tuple because it's a constant… - #254
Merged
Conversation
vstinner
approved these changes
Aug 31, 2026
vstinner
left a comment
Member
There was a problem hiding this comment.
This is really a pedantic change... It's a private constant in a private module, the constant is only used by tdist95conf_level().
This has no significant performance gain, but I think it would avoid the amortized space allocation for dynamic list in python which happens to avoid amortized O(N) complexity for append operation
_T_DIST_95_CONF_LEVELS is never modified, so this point is irrelevant.
I only approved the change to avoid someone else proposing a similar change in the future.
Contributor
Author
|
Sorry, I will be careful with the future code changes if I made any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_T_DIST_95_CONF_LEVELSnever modified in the later part of_utils.pyfile as it is only accessed so I thought it is reasonable to make it a tuple instead of the dynamic list.amortized space allocationfor dynamic list in python which happens to avoidamortized O(N)complexity forappendoperation