Repository navigation
Stop marking plugin-sabre-event as bundled - #156
Merged
Merged
Conversation
Psalm 7.2.0 no longer requires psalm/plugin-sabre-event, and Config::FIRST_PARTY_PLUGINS no longer enables it for sabre/event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The plugins page says
psalm/plugin-sabre-eventis "Included with Psalm 7. On automatically when composer.json requires sabre/event." That is no longer true: Psalm 7.2.0 dropped it from itsrequire(7.1.0 still hadpsalm/plugin-sabre-event: ^0.2.1), andConfig::FIRST_PARTY_PLUGINSno longer mapssabre/eventto it.Refs #0
Solution
The "bundled" flag already follows the latest Psalm release's
require, so the nextbin/update_plugin_list.phprun lists the plugin as a regular one. This removes the stalesabre/evententry fromBUNDLED_PLUGIN_LIBRARIES, the copy ofFIRST_PARTY_PLUGINS, so it matches Psalm again.The page keeps the old text until the list is rebuilt on the server.