Repository navigation
Baseline PropertyNotSetInConstructor reported at the returns of constructors - #17
Merged
Merged
Conversation
…ructors Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baselines the three
PropertyNotSetInConstructorthat vimeo/psalm#13085 reports where a constructor returns before it has initialised a property:ExecutionOrderDependency::$shallowClone/$deepClone(the invalid dependency returns early) andDefaultPrinter::$isPhpStream(thesocket://path returns before setting it, andflush()reads it).This repository holds PHPUnit 11.0. The three are real in this snapshot (reading them throws
Error: Typed property ... must not be accessed before initialization), but upstream PHPUnit has already fixed them: in 12.5, 13.4, 13.5 and main the constructors assign the properties before the early return, so there is nothing to report upstream.With the baseline both configs (
.psalm/config.xmland.psalm/static-analysis.xml) report no errors on vimeo/psalm#13085 (bdcc8fcf6).