Repository navigation
CI: real-tool smoke for pmd, solhint, hadolint, bandit, ruff and actionlint - #2362
Merged
Merged
Conversation
… actionlint The real-hub job now installs pinned, checksum-verified real scanners (pmd 7.29.0, solhint 6.2.5, hadolint 2.15.1, bandit 1.9.4, ruff 0.17.5, actionlint 1.7.12) and asserts each is reported as ran with its expected rule id on a fictional canary file. None needs a network DB at scan time. Locally verified: hadolint, bandit, ruff, actionlint; pmd and solhint are first exercised by CI. Tests: hadolint, bandit, ruff-security, actionlint canaries pass locally; actionlint ci.yml clean; size ok Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es outside cwd) solhint 6.2.5 throws a RangeError in its ignore filter (exit 255, no output) when the linted path is outside the working directory, so the throwaway canary under the review temp dir never raised avoid-tx-origin and the hub failed closed. The config and flags were correct (solhint:recommended includes avoid-tx-origin). The canary now runs after cd into its temp dir. The real-hub raw dump no longer pipes into head, which raised SIGPIPE under pipefail. Tests: 21/21 hub-pmd-solhint stub suite; real-hub solhint canary passes locally with solhint 6.2.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the real-hub CI job to six more scanners routed through review_checks.sh: pmd 7.29.0, solhint 6.2.5, hadolint 2.15.1, bandit 1.9.4, ruff 0.17.5 (security rules) and actionlint 1.7.12. Each tool installs at an exact version (binaries checked against upstream sha256), runs on one fictional canary file, and the job fails unless the tool ran, reported its expected rule on that file, and no not-run line appeared.
Until now these tools were tested with stub binaries only. hadolint, bandit, ruff and actionlint canaries pass locally; pmd and solhint are first verified by this PR's CI run.
Tests: canaries run in CI; actionlint, bash -n, the size gate, the size ratchet and the privacy grep pass locally.
🤖 Generated with Claude Code