fix: use XML hash for streaming shared strings#50
Open
gwkline wants to merge 1 commit intoprotobi:masterfrom
Open
fix: use XML hash for streaming shared strings#50gwkline wants to merge 1 commit intoprotobi:masterfrom
gwkline wants to merge 1 commit intoprotobi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSharedStringsenabled was causing strings to be incorrectly repeated, likely due to[object Object]counting as one string in the cache. This patch uses the XML representation of these strings for the purpose of cacheing to avoid this issueTest plan
Before:
After:
Related to source code (for typings update)