Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"nano-staged": "^1.0.2",
"oxfmt": "^0.71.0",
"pkg-pr-new": "^0.0.91",
"playwright": "^1.64.0",
"playwright": "1.65.0-alpha-2026-10-13",
"simple-git-hooks": "^2.14.0",
"typescript": "^6.0.3",
"vite": "^8.3.4",
Expand Down
6 changes: 2 additions & 4 deletions packages/react/src/components/cross-editor-drag.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { describe, expect, it } from 'vitest'
import { mouse } from 'vitest-browser-commands/playwright'
import { render } from 'vitest-browser-react'
import { page, server, type Locator } from 'vitest/browser'
import { page, type Locator } from 'vitest/browser'

import { hover, unhover } from '../testing/mouse.ts'

Expand Down Expand Up @@ -48,9 +48,7 @@
.not.toHaveAttribute('data-dragging')
}

// Playwright's WebKit reports the wrong `dropEffect` on `dragend`.
// https://github.com/microsoft/playwright/issues/43082
describe.skipIf(server.browser === 'webkit')('cross editor block drag', () => {
describe('cross editor block drag', () => {
it('moves the block into the other editor', async () => {
const from = createRef<EditorHandle>()
const to = createRef<EditorHandle>()
Expand All @@ -67,7 +65,7 @@
await expect.element(today.getByTestId('drop-indicator')).toBeVisible()
await drop()

expect(from.current?.getMarkdown()).toBe('Bravo\n')

Check failure on line 68 in packages/react/src/components/cross-editor-drag.test.tsx

View workflow job for this annotation

GitHub Actions / test-mac-webkit

[react-browser (webkit)] src/components/cross-editor-drag.test.tsx > cross editor block drag > moves the block into the other editor

AssertionError: expected 'Alpha\n\nBravo\n' to be 'Bravo\n' // Object.is equality - Expected + Received + Alpha + Bravo ❯ src/components/cross-editor-drag.test.tsx:68:41

Check failure on line 68 in packages/react/src/components/cross-editor-drag.test.tsx

View workflow job for this annotation

GitHub Actions / test-mac-webkit

[react-browser (webkit)] src/components/cross-editor-drag.test.tsx > cross editor block drag > moves the block into the other editor

AssertionError: expected 'Alpha\n\nBravo\n' to be 'Bravo\n' // Object.is equality - Expected + Received + Alpha + Bravo ❯ src/components/cross-editor-drag.test.tsx:68:41

Check failure on line 68 in packages/react/src/components/cross-editor-drag.test.tsx

View workflow job for this annotation

GitHub Actions / test-mac-webkit

[react-browser (webkit)] src/components/cross-editor-drag.test.tsx > cross editor block drag > moves the block into the other editor

AssertionError: expected 'Alpha\n\nBravo\n' to be 'Bravo\n' // Object.is equality - Expected + Received + Alpha + Bravo ❯ src/components/cross-editor-drag.test.tsx:68:41

Check failure on line 68 in packages/react/src/components/cross-editor-drag.test.tsx

View workflow job for this annotation

GitHub Actions / test-mac-webkit

[react-browser (webkit)] src/components/cross-editor-drag.test.tsx > cross editor block drag > moves the block into the other editor

AssertionError: expected 'Alpha\n\nBravo\n' to be 'Bravo\n' // Object.is equality - Expected + Received + Alpha + Bravo ❯ src/components/cross-editor-drag.test.tsx:68:41
expect(to.current?.getMarkdown()).toBe('Alpha\n\nCharlie\n')
})

Expand Down
42 changes: 21 additions & 21 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ minimumReleaseAgeExclude:
- eslint-plugin-ocavue
- vitest-browser-commands
- prosemirror-flat-list
- playwright-core@1.65.0-alpha-2026-10-13
- playwright@1.65.0-alpha-2026-10-13

allowBuilds:
esbuild: false
Expand Down
Loading