Media export: Reimplement recursive directory listing while doing PRFS backup#32
Merged
Conversation
Contributor
Author
|
after i test it with a full backup i will mark it for review |
Contributor
Author
|
works as intended, tested on an iPhone running ios 27 beta, it skipped directory that was causing issues and it still only extracts files not found in a backup |
sandrzejewskipl
marked this pull request as ready for review
July 26, 2026 18:26
Owner
|
Thanks for the input. It looks good overall. I won't be able to test it until tomorrow. If it doesn't break anything else, I'll merge it as is. |
Owner
|
Tested without problems. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reimplements pymobiledevice3's dirlist() by skipping directories that we don't have access to. Currently, when dirlist() encounters a directory that throws an exception, the entire backup process fails, causing all progress to be lost. With this change, the problematic directory will be skipped and logged:
26/07/2026 15:24:35: Error listing directory /PhotoData/UBF: [Errno 10] Opcode: READ_DIR failed with status: 10: Nonefixes #31