Skip to content

fix(infiniband): skip sysfs reads for excluded devices #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pujitha24 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(infiniband): skip sysfs reads for excluded devices #3824

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91b36f1
fix(infiniband): skip sysfs reads for excluded devices
pujitha24 Sep 19, 2026
2bf0987
Merge branch 'master' into auto/issue-3823
SuperQ Oct 28, 2026
83e2077
Update collector/infiniband_linux.go
SuperQ Oct 28, 2026
5df1f21
infiniband: drop ad-hoc sysfs-writing test
pujitha24 Oct 28, 2026
46b7902
Merge branch 'master' into auto/issue-3823
SuperQ Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions collector/infiniband_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (c *infinibandCollector) pushCounter(ch chan<- prometheus.Metric, name stri
}

func (c *infinibandCollector) Update(ch chan<- prometheus.Metric) error {
devices, err := c.fs.InfiniBandClass()
deviceNames, err := c.fs.InfiniBandClassDevices()
if err != nil {
if errors.Is(err, os.ErrNotExist) {
c.logger.Debug("infiniband statistics not found, skipping")
Expand All @@ -167,11 +167,16 @@ func (c *infinibandCollector) Update(ch chan<- prometheus.Metric) error {
return fmt.Errorf("error obtaining InfiniBand class info: %w", err)
}

for _, device := range devices {
if c.deviceFilter.ignored(device.Name) {
for _, name := range deviceNames {
if c.deviceFilter.ignored(name) {
continue
}

device, err := c.fs.InfiniBandDevice(name)
if err != nil {
return fmt.Errorf("error obtaining InfiniBand device info: %w", err)
}

infoDesc := prometheus.NewDesc(
prometheus.BuildFQName(namespace, c.subsystem, "info"),
"Non-numeric data from /sys/class/infiniband/<device>, value is always 1.",
Expand Down
Loading