web: mark prefer_server_cipher_suites as deprecated and ignored - #444
Merged
ArthurSens merged 1 commit intoSep 3, 2026
Merged
Conversation
The documentation gives this setting a four line explanation of how it changes cipher selection, and it has not done anything for years. It was passed to tls.Config.PreferServerCipherSuites, whose own documentation reads "PreferServerCipherSuites is a legacy field and has no effect"; Go has selected the cipher suite itself since Go 1.17. Operators tuning it are tuning a knob that is not connected to anything. Say so in the documentation and on the struct field, and stop passing the value to tls.Config, which also removes a use of a deprecated standard library field. The YAML key is still parsed and still defaults to true, so existing configuration files keep loading unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation gives
prefer_server_cipher_suitesa four-line explanation of how it changes cipher selection, and it has not done anything for years.It is passed to
tls.Config.PreferServerCipherSuites, whose own documentation reads:Go has selected the cipher suite itself since Go 1.17. Operators tuning this are tuning a knob that is not connected to anything.
Change
Say so in the documentation and on the struct field, and stop passing the value to
tls.Config— which also removes a use of a deprecated standard library field. The YAML key is still parsed and still defaults totrue, so existing configuration files keep loading unchanged.🤖 Generated with Claude Code