Add http debugging roundtripper - #985
Open
jaymzh wants to merge 1 commit into
Open
Conversation
When developing things (like prometheus#962), it's useful to be able to debug the http roundtrips. This adds `debugRoundTripper` that other prom tools can use (behind a `--http.debug` flag) which automatically logs the HTTP requests while redacting credentials. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/alertmanager
that referenced
this pull request
Sep 3, 2026
This depends on prometheus/common#985 for the infrastructure, but adds an --http.debug flag that uses the prometheus/common debug roundtripper to provide debug logs with credentials censored. Signed-off-by: Phil Dibowitz <phil@ipom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When developing things (like #962), it's useful to be able
to debug the http roundtrips. This adds
debugRoundTripperthat other promtools can use (behind a
--http.debugflag) which automaticallylogs the HTTP requests while redacting credentials.
Implemented downstream usage for promtool and amtool: prometheus/prometheus#19577 and prometheus/alertmanager#5541
Signed-off-by: Phil Dibowitz phil@ipom.com