Repository navigation
fix: keep counting after remove() without labels - #2701
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
A metric without labels caches its data point. remove() and removeIf() dropped the data point but kept the cached reference, so later updates went to an orphan and were never exported. clear() already resets the cache. Signed-off-by: Sharang Gupta <sharang@sharanggupta.dev>
sharanggupta
requested review from
dhoard,
fstab,
jaydeluca and
zeitlinger
as code owners
November 18, 2026 23:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A metric without labels caches its data point.
remove()andremoveIf()drop the data point but keep the cached reference, so aftercounter.remove()every latercounter.inc()updates an orphan and the counter is exported as 0.clear()already resets the cache (#972);remove()andremoveIf()now do the same. The two newStatefulMetricTestcases fail without the change.