Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<awaitility.version>4.3.0</awaitility.version>
<wiremock.version>3.13.2</wiremock.version>
<junit-jupiter.version>6.1.3</junit-jupiter.version>
<otel.instrumentation.version>2.32.0-alpha</otel.instrumentation.version>
<otel.instrumentation.version>2.33.1-alpha</otel.instrumentation.version>
<java.version>8</java.version>
<test.java.version>25</test.java.version>
<!-- Bumped by .github/workflows/bump-api-diff-baseline.yml after each release. -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
import io.opentelemetry.proto.metrics.v1.Metric;
import io.opentelemetry.proto.metrics.v1.NumberDataPoint;
import io.opentelemetry.proto.metrics.v1.ResourceMetrics;
import io.opentelemetry.sdk.testing.exporter.InMemorySpanExporter;
import io.opentelemetry.sdk.trace.SdkTracerProvider;
import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor;
import io.opentelemetry.sdk.trace.samplers.Sampler;
import io.prometheus.metrics.core.metrics.Counter;
import io.prometheus.metrics.model.registry.PrometheusRegistry;
Expand Down Expand Up @@ -74,7 +76,11 @@ void tearDown() {
@SuppressWarnings("try")
public void sampledExemplarIsForwarded() {
try (SdkTracerProvider sdkTracerProvider =
SdkTracerProvider.builder().setSampler(Sampler.alwaysOn()).build()) {
SdkTracerProvider.builder()
.setSampler(Sampler.alwaysOn())
// SDK >= 1.67 returns a no-op tracer if no span processor is registered
.addSpanProcessor(SimpleSpanProcessor.create(InMemorySpanExporter.create()))
.build()) {

Tracer test = sdkTracerProvider.get(INSTRUMENTATION_SCOPE_NAME);
Span span = test.spanBuilder(SPAN_NAME).startSpan();
Expand All @@ -100,7 +106,11 @@ public void sampledExemplarIsForwarded() {
@SuppressWarnings("try")
public void notSampledExemplarIsNotForwarded() {
try (SdkTracerProvider sdkTracerProvider =
SdkTracerProvider.builder().setSampler(Sampler.alwaysOff()).build()) {
SdkTracerProvider.builder()
.setSampler(Sampler.alwaysOff())
// SDK >= 1.67 returns a no-op tracer if no span processor is registered
.addSpanProcessor(SimpleSpanProcessor.create(InMemorySpanExporter.create()))
.build()) {

Tracer test = sdkTracerProvider.get(INSTRUMENTATION_SCOPE_NAME);
Span span = test.spanBuilder(SPAN_NAME).startSpan();
Expand Down
Loading