update inhibitor index to store all matched alerts - #5542
Draft
Spaceman1701 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
Spaceman1701
force-pushed
the
fix-inhibitor
branch
from
September 4, 2026 15:14
ac57906 to
1a56009
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is based on HRT's inhibitor implementation. It updates the index so that each equal-labels key holds a
FingerprintSetinstead of aFingerprintso that the index stores every matching source alert instead of one matching source alert.This allows the inhibitor to search through all the alerts in the index for the set of equal-labels to select the best candidate. Worst case, this does degrade inhibitor performance to
O(n), but in practice it should be similar to today (since the first element of the set is most likely a viable candidate).