Skip to content

feat(ui): add mantine burger menu navigation #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siavashs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui): add mantine burger menu navigation #5539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion ui/mantine-ui/src/App.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { render, screen } from '@testing-library/react';
import { render, screen, within } from '@testing-library/react';
import userEvent from '@testing-library/user-event';

import App from './App';
import headerClasses from './components/Header.module.css';
Expand All @@ -21,4 +22,28 @@ describe('App routing', () => {

expect(screen.getByRole('banner')).toHaveClass(headerClasses.header);
});

it('provides navigation from the mobile menu', async () => {
const user = userEvent.setup();
render(<App />);

const menuButton = screen.getByRole('button', { name: 'Toggle navigation menu' });
await user.click(menuButton);

expect(menuButton).toHaveAttribute('aria-expanded', 'true');

const menu = await screen.findByRole('menu', { hidden: true });
const activeMenuItem = within(menu).getByRole('menuitem', { name: 'Alerts', hidden: true });
expect(activeMenuItem).toHaveAttribute('aria-current', 'page');
expect(activeMenuItem).toHaveClass(headerClasses.menuItem);
expect(
within(menu).getByRole('menuitem', { name: 'Silences', hidden: true })
).toBeInTheDocument();
expect(
within(menu).getByRole('menuitem', { name: 'Runtime & Build Information', hidden: true })
).toBeInTheDocument();
expect(
within(menu).getByRole('menuitem', { name: 'Configuration', hidden: true })
).toBeInTheDocument();
});
});
7 changes: 7 additions & 0 deletions ui/mantine-ui/src/components/Header.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,10 @@
color: var(--mantine-color-white);
}
}

.menuItem {
&[aria-current="page"] {
background-color: var(--mantine-color-blue-filled);
color: var(--mantine-color-white);
}
}
47 changes: 40 additions & 7 deletions ui/mantine-ui/src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { AppShell, Button, Group, Menu, Text } from '@mantine/core';
import { AppShell, Burger, Button, Group, Menu, Text } from '@mantine/core';
import { useDisclosure } from '@mantine/hooks';
import { Link, NavLink, Route, Routes } from 'react-router-dom';

import { AlertsPage } from '@/pages/Alerts.page';
Expand All @@ -9,6 +10,8 @@ import classes from './Header.module.css';
const navLinkXPadding = 'md';

export const Header = () => {
const [mobileMenuOpened, { open, close }] = useDisclosure(false);

const mainNavPages = [
{
title: 'Alerts',
Expand Down Expand Up @@ -99,6 +102,38 @@ export const Header = () => {
</>
);

const mobileNavLinks = (
<Menu
opened={mobileMenuOpened}
onChange={(opened) => (opened ? open() : close())}
menuItemTabIndex={0}
trapFocus={false}
position="bottom-end"
>
<Menu.Target>
<Burger opened={mobileMenuOpened} color="white" aria-label="Toggle navigation menu" />
</Menu.Target>
<Menu.Dropdown>
{mainNavPages.map((page) => (
<Menu.Item
key={page.path}
className={classes.menuItem}
component={NavLink}
to={page.path}
>
{page.title}
</Menu.Item>
))}
<Menu.Item className={classes.menuItem} component={NavLink} to="/status">
Runtime & Build Information
</Menu.Item>
<Menu.Item className={classes.menuItem} component={NavLink} to="/config">
Configuration
</Menu.Item>
</Menu.Dropdown>
</Menu>
);

return (
<AppShell.Header className={classes.header}>
<Group h="100%" px="md" wrap="nowrap">
Expand All @@ -107,17 +142,15 @@ export const Header = () => {
<Link to="/" style={{ textDecoration: 'none', color: 'white' }}>
<Group gap={10} wrap="nowrap">
{/* <img src={PrometheusLogo} height={30} /> */}
<Text hiddenFrom="sm" fz={20}>
Alertmanager
</Text>
<Text visibleFrom="md" fz={20}>
Alertmanager
</Text>
<Text fz={20}>Alertmanager</Text>
</Group>
</Link>
<Group gap={12} visibleFrom="sm" wrap="nowrap">
{navLinks}
</Group>
<Group hiddenFrom="sm" ml="auto" wrap="nowrap">
{mobileNavLinks}
</Group>
</Group>
</Group>
</Group>
Expand Down
Loading