feat(ui): migrate mantine to StatusService v3alpha - #5538
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe Mantine UI now generates TypeScript protobuf bindings, creates a Connect RPC transport, queries ChangesMantine Connect integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Generated UI bindings are excluded from formatting and linting only; build and runtime availability remains intact. No current merge-blocking risk is identified. Sequence Diagram(s)sequenceDiagram
participant App
participant TransportProvider
participant StatusPage
participant StatusService
participant API
App->>TransportProvider: provide apiTransport
StatusPage->>StatusService: request getStatus
StatusService->>API: send HTTP GET Connect request
API-->>StatusService: return status response
StatusService-->>StatusPage: provide validated status
StatusPage->>StatusPage: render start time and cluster state
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 9 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- replace the Mantine UI's hand-written API v2 status model - use generated Protobuf-ES bindings for status.v3alpha.StatusService - use Connect-Query with a route-prefix-aware Connect-Web transport - render the new start time and cluster state fields - add coverage for generation, transport routing, response validation, and page rendering Signed-off-by: Siavash Safi <siavash@cloudflare.com>
34a3282 to
2adc222
Compare
Uh oh!
There was an error while loading. Please reload this page.