Add LICENSE and NOTICE to container image - #1380
Open
locker95 wants to merge 1 commit into
Open
Conversation
Copy LICENSE and NOTICE into the Docker image, matching what the release tarballs already ship and the prometheus/prometheus Dockerfile convention. Fixes prometheus-community#1206 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container images published for postgres_exporter only contain the binary, so anyone redistributing the image has no copy of the Apache-2.0 license text or the NOTICE file, even though
.promu.ymlalready ships both in the release tarballs. This was reported in #1206, where SuperQ noted it's "Probably worth adding a COPY to the Dockerfile."This adds
COPY LICENSE /LICENSEandCOPY NOTICE /NOTICEto the Dockerfile, following the same convention as the prometheus/prometheus Dockerfile. Both files live at the repo root, which is the docker build context (DOCKERBUILD_CONTEXT ?= ./), and neither is excluded by.dockerignore, so no other changes are needed.Fixes #1206