collector.wal: add pg_wal_lsn_location_bytes - WAL LSN bytes - #1188
Open
kmoppel wants to merge 2 commits into
Open
collector.wal: add pg_wal_lsn_location_bytes - WAL LSN bytes#1188kmoppel wants to merge 2 commits into
kmoppel wants to merge 2 commits into
Conversation
Contributor
Author
|
ping :) |
This is used commonly to monitor WAL writing intensity or rate in MB/s, an essential indicator basically for planning WAL archiving / RPO disk capacity. Signed-off-by: Kaarel Moppel <kaarel.moppel@gmail.com>
kmoppel
force-pushed
the
add-wal-lsn-location-to-wal-collector
branch
from
June 22, 2026 10:36
5b423a6 to
bf361d7
Compare
Signed-off-by: Kaarel Moppel <kaarel.moppel@gmail.com>
kmoppel
force-pushed
the
add-wal-lsn-location-to-wal-collector
branch
from
June 22, 2026 10:45
bf361d7 to
c9649f7
Compare
ArthurSens
reviewed
Aug 24, 2026
ArthurSens
left a comment
ArthurSens
left a comment
Contributor
There was a problem hiding this comment.
Hey @kmoppel, sorry for the super delayed review here!
| var segments uint64 | ||
| var size sql.NullInt64 | ||
| err := row.Scan(&segments, &size) | ||
| var lsnbytes uint64 |
Contributor
There was a problem hiding this comment.
Reading the docs seems to suggest that LSN can be NULL if WAL replay hasn't started yet. Casting NULL to uint64 would cause an error and stop the creation of all other metrics. Could we use NullUint64 here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used commonly to monitor WAL writing intensity or rate in MB/s, an essential indicator basically for planning WAL archiving / RPO disk capacity.