Repository navigation
Conversation
vshntea
force-pushed
the
reimplement
branch
2 times, most recently
from
September 25, 2026 13:54
c2bc958 to
4c50fc5
Compare
BacLuc
reviewed
Sep 25, 2026
BacLuc
approved these changes
Sep 25, 2026
This repository hasn't been touched in 5 years. Changes have been made from the ground up, I only found out about this component after it was implemented locally.
vshntea
force-pushed
the
reimplement
branch
from
September 28, 2026 09:41
4c50fc5 to
849d3c0
Compare
BacLuc
approved these changes
Sep 28, 2026
simu
reviewed
Sep 28, 2026
Comment on lines
+11
to
+12
| charts: | ||
| chart1: |
Member
There was a problem hiding this comment.
There's no need to blindly adhere to Project Syn best practices when you sidestep commodore-renovate's Helm chart support anyway by using a regex manager.
simu
reviewed
Sep 28, 2026
| Use an alias for the component. | ||
| The parent key for all of the following parameters is `helm_chart`. | ||
|
|
||
| The component is multi-tenant, multi-instance and multi-version aware. Each |
Member
There was a problem hiding this comment.
Please keep docs at one sentence per line.
Comment on lines
+5
to
+7
| The component is multi-tenant, multi-instance and multi-version aware. Each | ||
| instance is compiled with `--alias <instance>` and can override the parameters | ||
| below. |
Member
There was a problem hiding this comment.
Second sentence is mostly irrelevant to anyone using the component.
Comment on lines
13
to
15
| { | ||
| [instance]: app, | ||
| ['%s/%s' % [ appPath, instance ]]: app, | ||
| } |
Member
There was a problem hiding this comment.
I'd probably make not instantiating this component an error, something along the lines of doing
if instance == 'helm-chart' then
error 'Component helm-chart must be instantiated with `helm-chart as foo` when using it.'
else {
['%s/%s' % [ appPath, instance ]: app,
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository hasn't been touched in 5 years. Changes have been made from the ground up, I only found out about this component after it was implemented locally.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog