[bacluc-agent]

Related issue: https://github.com/bacluc-agent/agent-vshn-todo/issues/76

Summary

Adds an EditorConfig auto-fix path to the rendered component template and wires it into CI.

• New format_editorconfig make target using npx --yes eclint@$(ECLINT_VERSION) fix ..
• ECLINT_VERSION ?= 2.8.1 pin in {{ cookiecutter.slug }}/Makefile.vars.mk with a # renovate: datasource=npm depName=eclint annotation.
• format target now runs format_jsonnet format_editorconfig; lint/all are untouched.
• CI editorconfig job now runs make format_editorconfig followed by git diff --exit-code, replacing the snow-actions/eclint@v1.0.1 action.
• Root renovate.json: regex customManager with slash-wrapped managerFilePatterns (/^...$/) matching {{ cookiecutter.slug }}/Makefile.vars.mk, so the ECLINT_VERSION pin is picked up.
• {{ cookiecutter.slug }}/.github/changelog-configuration.json: {% endraw %} → {% endraw -%} so the rendered file ends with }\n (no trailing blank line). Without this, eclint fix strips the trailing blank line and git diff --exit-code would fail in CI on every component.

No CI runs on fork PRs; all verification below was performed locally.

Verification

Template rendered with cruft (2.10.x) from the committed HEAD, using 6 option combos of add_golden/add_matrix/add_go_unit: y y n, n n n, y y y, y n n, n y y, n n y.

1. Rendered content (all 6 combos, exit 0 each):

   • format: format_jsonnet format_editorconfig ## All-in-one formatting present; format_editorconfig: ## Fix EditorConfig issues present; recipe uses a real TAB (sed -n '47p' Makefile | cat -A → ^Inpx --yes eclint@$(ECLINT_VERSION) fix .).
   • Makefile.vars.mk has ECLINT_VERSION ?= 2.8.1.
   • snow-actions/eclint absent from rendered .github/workflows/test.yaml; editorconfig: job contains make format_editorconfig and git diff --exit-code.

2. Fixer no-op on fresh render (all 6 combos): git init && git add -A && git commit then make format_editorconfig → make exit 0, git status --porcelain = 0 lines, git diff --exit-code exit 0.

3. Deliberate violation (combo y y n): printf 'key: value \n' > bad.yaml + commit, then make format_editorconfig → git diff -- bad.yaml shows key: value → key: value, git diff --exit-code exit 1 (fixer did real work). bad.yaml removed afterwards.

4. Idempotency: two consecutive make format_editorconfig runs → exit 0/0, tree clean after second run (0 porcelain lines, diff exit 0).

5. Old template control (upstream de8e8df, same render options): npx --yes eclint@2.8.1 fix . rewrites only .github/changelog-configuration.json (removes trailing blank line):

    M .github/changelog-configuration.json
   @@ -29,4 +29,3 @@
        "template": "..."
    }
    -
   

   With the {% endraw -%} fix, the new template produces zero rewrites (step 2).

6. Workflow lint (all 6 combos): yamllint -f parsable -c .yamllint.yml --no-warnings -- .github/workflows/test.yaml → exit 0 for all 6. docker run --rm -v "$PWD":/repo -w /repo rhysd/actionlint:latest → exit 0 for the add_go_unit=n combos (y y n, n n n, y n n); combos with add_go_unit=y report a pre-existing SC2086 in the unrelated "Determine Go version from go.mod" step. Confirmed pre-existing by running actionlint on a control render of upstream de8e8df with the same options (same finding at line 44, exit 1). Not caused by this change; out of scope.

7. Renovate (npx --yes --package renovate@44.168.4 renovate-config-validator renovate.json, no --strict) → exit 0, only the pre-existing config:base → config:recommended migration WARN. Matching self-check: slash-wrapped managerFilePatterns matches {{ cookiecutter.slug }}/Makefile.vars.mk and not bare Makefile.vars.mk; matchStrings extracts {'datasource': 'npm', 'depName': 'eclint', 'currentValue': '2.8.1'}.

8. make help (rendered component): shows format_editorconfig Fix EditorConfig issues.

Test evidence

No CI runs on fork PRs; verification was local (see commands and exit codes above).

Assumptions

• Root renovate.json targets the template repository's own Renovate runs; the rendered component's renovate.json is generated by hooks/post_gen_project.py and is intentionally unchanged.
• ECLINT_VERSION = 2.8.1 is the current npm latest for eclint.
• The pre-existing actionlint SC2086 warning is left untouched as out of scope.

[BacLuc]

Sorry for that. Agent should have opened the PR against a fork.