Repository navigation
feat: Ship sveltos-dashboard-viewer and sveltos-dashboard-editor ClusterRoles - #200
Merged
gianlucam76 merged 1 commit intoOct 31, 2026
Conversation
gianlucam76
force-pushed
the
dashboard-viewer-editor-clusterroles
branch
2 times, most recently
from
October 31, 2026 17:34
7a00ce6 to
381a03f
Compare
…terRoles With OIDC login the dashboard acts as the user, so operators need roles to bind their groups to. The only documented option was cluster-admin. sveltos-dashboard-viewer grants read access to every kind the dashboard checks with SubjectAccessReviews. sveltos-dashboard-editor adds create, update, patch and delete on ClusterProfiles and Profiles. Neither role grants access to ConfigMaps or Secrets, which must be granted with a namespaced Role. The roles live in config/user-rbac, separate from config/default, so the ui-backend- name prefix is not applied to them. The manifests target appends them to manifest/manifest.yaml. Envtest-based specs load the shipped YAML and check it against the same SubjectAccessReviews ui-backend issues, so the roles cannot drift from the code.
gianlucam76
force-pushed
the
dashboard-viewer-editor-clusterroles
branch
from
October 31, 2026 17:55
381a03f to
2fded09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With OIDC login the dashboard acts as the user, so operators need roles to bind their groups to. The only documented option was cluster-admin.
sveltos-dashboard-viewer grants read access to every kind the dashboard checks with SubjectAccessReviews. sveltos-dashboard-editor adds create, update, patch and delete on ClusterProfiles and Profiles. Neither role grants access to ConfigMaps or Secrets, which must be granted with a namespaced Role.
The roles live in config/user-rbac, separate from config/default, so the ui-backend- name prefix is not applied to them. The manifests target appends them to manifest/manifest.yaml.
Envtest-based specs load the shipped YAML and check it against the same SubjectAccessReviews ui-backend issues, so the roles cannot drift from the code.
Part of 234