Repository navigation
fix: Return copies of the cached maps, not the live ones - #196
Merged
gianlucam76 merged 1 commit intoOct 19, 2026
Merged
Conversation
GetManagedSveltosClusters, GetManagedCAPIClusters, GetClusterProfileStatuses and GetProfiles returned the cached map itself. The read lock was released on return, so the HTTP handlers iterated the map without any lock while the controllers kept updating it. Go aborts the process on a concurrent map iteration and write: with SveltosClusters being updated while clients listed clusters, ui-backend crashed with "fatal error: concurrent map iteration and map write". The getters now return a copy made while holding the lock. The RemoveProfile spec kept a map obtained before the removal and relied on it being the live cache. It now reads the profiles again after the removal. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetManagedSveltosClusters, GetManagedCAPIClusters, GetClusterProfileStatuses and GetProfiles returned the cached map itself. The read lock was released on return, so the HTTP handlers iterated the map without any lock while the controllers kept updating it. Go aborts the process on a concurrent map iteration and write: with SveltosClusters being updated while clients listed clusters, ui-backend crashed with "fatal error: concurrent map iteration and map write".
The getters now return a copy made while holding the lock.
The RemoveProfile spec kept a map obtained before the removal and relied on it being the live cache. It now reads the profiles again after the removal.