Repository navigation
fix: List unhealthy resources even when no profile enables health monitoring - #194
Merged
Merged
Conversation
…itoring Bumps addon-controller to pick up the change in lib/healthmonitoring. Unhealthy resources are now listed whether or not a profile has health monitoring enabled. Before, the dashboard showed "Health monitoring is not enabled" while HealthCheckReports had Degraded resources, but listed them all once any profile enabled monitoring. - A cluster with health reports and no profile with monitoring enabled now gets a health state and a badge. NotEnabled means no enabled profile and no report. - Resources reported by a HealthCheck no profile owns are listed with healthCheckName instead of profiles. - When a resource is reported by several HealthChecks, it is listed once. Status and message come from the profile-owned reports when there are any, otherwise the worst status wins. - /clusterHealth lists resources owned by a profile first, then the others, each group worst status first. Pagination is unchanged. - No logic change in ui-backend itself: the cache already stores every report. I updated the doc comments and README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps addon-controller to pick up the change in lib/healthmonitoring.
Unhealthy resources are now listed whether or not a profile has health monitoring enabled. Before, the dashboard showed "Health monitoring is not enabled" while HealthCheckReports had Degraded resources, but listed them all once any profile enabled monitoring.