Repository navigation
feat: add --watch-namespaces to register cluster --pullmode - #451
Merged
gianlucam76 merged 1 commit intoSep 18, 2026
Merged
Conversation
- sveltosctl register cluster --pullmode generated a YAML wits --watch-namespaces= always empty and no annotation on the created SveltosCluster, so a freshly registered cluster ran with sveltos-applier unrestricted - Adds a --watch-namespaces=<value> flag to register cluster, valid only with --pullmode, which sets the agent.projectsveltos.io/watch-namespaces annotation on the created SveltosCluster and the --watch-namespaces flag in the generated sveltos-applier manifest to the same value. - Also fixes a latent bug in updateSveltosClusterLabelsAndAnnotations patchSveltosCluster-adjacent code: setting the shard annotation replaced the whole Annotations map instead of merging into it, which would have silently dropped the new watch-namespaces annotation (and vice versa) on any update to an existing SveltosCluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent.projectsveltos.io/watch-namespaces annotation on the created SveltosCluster and the --watch-namespaces flag in the generated sveltos-applier manifest to the same value.