Repository navigation
add tests for deployment template arg helpers - #228
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
setOptions and appendArgsToContainer manipulate the generated deployment templates used to deploy addon-controller, classifier, event-manager and healthcheck-manager per shard, but had no test coverage at all. Same for addDriftDetectionConfig and addClassifierConfigs which wrap appendArgsToContainer for specific flags. Covers replacing an existing agent-in-mgmt-cluster arg, idempotency when applied twice, only touching the matching container, skipping empty values, and no-op behavior when nothing needs to change. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setOptions and appendArgsToContainer manipulate the generated deployment templates used to deploy addon-controller, classifier, event-manager and healthcheck-manager per shard, but had no test coverage at all. Same for addDriftDetectionConfig and addClassifierConfigs which wrap appendArgsToContainer for specific flags.
Covers replacing an existing agent-in-mgmt-cluster arg, idempotency when applied twice, only touching the matching container, skipping empty values, and no-op behavior when nothing needs to change.
Tested with go build, go vet, and the full envtest suite (37/37 passing).